Fix for setting dynamically the footprint_clearing_enabled parameter in the StaticLayer costmap_2d plugin (backport #4885)#4886
Merged
SteveMacenski merged 1 commit intojazzyfrom Jan 30, 2025
Conversation
the else condition is a duplication of the one before and was so never executed. Signed-off-by: Georg Flick <georg.flick@enway.ai> (cherry picked from commit 447c8ce)
Contributor
Author
SteveMacenski
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the StaticLayer costmap2d_plugin , the parameter
footprint_clearing_enabledwas never changed dynamically in the callback, because theelse ifcondition has a duplicated condition (same as in line 490 and line 500), so it never executed setting that parameter.Basic Info
Description of contribution in a few bullet points
footprint_clearing_enabledvia a ros2 callbackelse ifcondition was a duplicate of the one before, so it was never executed. This change is fixing it.Description of documentation updates required from your changes
Not needed.
Description of how this change was tested
ros2 param set /local_costmap/local_costmap obstacle_layer.footprint_clearing_enabled Falseor True to disable/enable itFuture work that may be required in bullet points
None
For Maintainers:
This is an automatic backport of pull request #4885 done by [Mergify](https://mergify.com).