- Modified findVelocitySignChange method to transform cusp into robot…#3036
Merged
SteveMacenski merged 15 commits intoros-navigation:mainfrom Jun 23, 2022
Merged
- Modified findVelocitySignChange method to transform cusp into robot…#3036SteveMacenski merged 15 commits intoros-navigation:mainfrom
SteveMacenski merged 15 commits intoros-navigation:mainfrom
Conversation
… frame before returning distance_to_cusp
Contributor
|
@stevenbrills, please properly fill in PR template in the future. @SteveMacenski, use this instead.
|
Contributor
|
@stevenbrills, your PR has failed to build. Please check CI outputs and resolve issues. |
nav2_regulated_pure_pursuit_controller/src/regulated_pure_pursuit_controller.cpp
Show resolved
Hide resolved
added 5 commits
June 22, 2022 09:41
…n different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed.
…n different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. Signed-off-by: Steven Brills <sbrills@hotmail.com>
…an in robot's frame - Removed need to pass pose to the findVelocitySignChange function
Contributor
|
@stevenbrills, your PR has failed to build. Please check CI outputs and resolve issues. |
…dVelocitySignChange expects. Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
Contributor
|
@stevenbrills, your PR has failed to build. Please check CI outputs and resolve issues. |
…object. Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
Contributor
|
@stevenbrills, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
SteveMacenski
approved these changes
Jun 22, 2022
Member
|
@stevenbrills the tests for RPP failed (or crash / hung) on |
…nce transformed plan is to be used. Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
Contributor
|
@stevenbrills, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
Contributor
|
@stevenbrills, your PR has failed to build. Please check CI outputs and resolve issues. |
Member
|
Please check out the branch locally do to development and commit and push when things are compiling please 😄 We only have so many resources for CI and the maintainers also get emails for every failed build |
Contributor
|
@stevenbrills, your PR has failed to build. Please check CI outputs and resolve issues. |
added 3 commits
June 23, 2022 16:06
…ansformed_plan instead
…ansformed_plan instead Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
Contributor
Author
|
The tests for RPP are passing now. |
Member
|
Thanks for the patch and contribution from a fellow Steven! |
Contributor
Author
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
#3036) * - Modified findVelocitySignChange method to transform cusp into robot frame before returning distance_to_cusp * - Previous commit had incorrect usage of method transformPose based on different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. * - Previous commit had incorrect usage of method transformPose based on different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. Signed-off-by: Steven Brills <sbrills@hotmail.com> * Failed lint check due to stray blank line. Removed the blank line * - Modified findVelocitySignChange function to take the transformed plan in robot's frame - Removed need to pass pose to the findVelocitySignChange function * - Modified the test file to reflect change in new parameters that findVelocitySignChange expects. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Corrected call to transformGlobalPoseWrapper method of BasicAPIRPP object. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - transformGlobalPlanWrapper call bug fix Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Updated tests now require frame_id and time_stamp for conversion since transformed plan is to be used. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Missing ; in test method Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead Signed-off-by: Steven Brills <stevenbrills@hotmail.com> Co-authored-by: Steven Brills <sbrills@aethon.com> (cherry picked from commit 99bec08)
SteveMacenski
pushed a commit
that referenced
this pull request
Jun 24, 2022
#3036) (#3041) * - Modified findVelocitySignChange method to transform cusp into robot frame before returning distance_to_cusp * - Previous commit had incorrect usage of method transformPose based on different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. * - Previous commit had incorrect usage of method transformPose based on different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. Signed-off-by: Steven Brills <sbrills@hotmail.com> * Failed lint check due to stray blank line. Removed the blank line * - Modified findVelocitySignChange function to take the transformed plan in robot's frame - Removed need to pass pose to the findVelocitySignChange function * - Modified the test file to reflect change in new parameters that findVelocitySignChange expects. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Corrected call to transformGlobalPoseWrapper method of BasicAPIRPP object. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - transformGlobalPlanWrapper call bug fix Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Updated tests now require frame_id and time_stamp for conversion since transformed plan is to be used. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Missing ; in test method Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead Signed-off-by: Steven Brills <stevenbrills@hotmail.com> Co-authored-by: Steven Brills <sbrills@aethon.com> (cherry picked from commit 99bec08) Co-authored-by: stevenbrills <90438581+stevenbrills@users.noreply.github.com>
redvinaa
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Jun 30, 2022
ros-navigation#3036) * - Modified findVelocitySignChange method to transform cusp into robot frame before returning distance_to_cusp * - Previous commit had incorrect usage of method transformPose based on different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. * - Previous commit had incorrect usage of method transformPose based on different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. Signed-off-by: Steven Brills <sbrills@hotmail.com> * Failed lint check due to stray blank line. Removed the blank line * - Modified findVelocitySignChange function to take the transformed plan in robot's frame - Removed need to pass pose to the findVelocitySignChange function * - Modified the test file to reflect change in new parameters that findVelocitySignChange expects. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Corrected call to transformGlobalPoseWrapper method of BasicAPIRPP object. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - transformGlobalPlanWrapper call bug fix Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Updated tests now require frame_id and time_stamp for conversion since transformed plan is to be used. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Missing ; in test method Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead Signed-off-by: Steven Brills <stevenbrills@hotmail.com> Co-authored-by: Steven Brills <sbrills@aethon.com>
jwallace42
pushed a commit
to jwallace42/navigation2
that referenced
this pull request
Dec 14, 2022
ros-navigation#3036) * - Modified findVelocitySignChange method to transform cusp into robot frame before returning distance_to_cusp * - Previous commit had incorrect usage of method transformPose based on different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. * - Previous commit had incorrect usage of method transformPose based on different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. Signed-off-by: Steven Brills <sbrills@hotmail.com> * Failed lint check due to stray blank line. Removed the blank line * - Modified findVelocitySignChange function to take the transformed plan in robot's frame - Removed need to pass pose to the findVelocitySignChange function * - Modified the test file to reflect change in new parameters that findVelocitySignChange expects. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Corrected call to transformGlobalPoseWrapper method of BasicAPIRPP object. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - transformGlobalPlanWrapper call bug fix Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Updated tests now require frame_id and time_stamp for conversion since transformed plan is to be used. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Missing ; in test method Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead Signed-off-by: Steven Brills <stevenbrills@hotmail.com> Co-authored-by: Steven Brills <sbrills@aethon.com>
borongyuan
added a commit
to borongyuan/navigation2
that referenced
this pull request
Jan 4, 2023
ros-navigation#3036) * - Modified findVelocitySignChange method to transform cusp into robot frame before returning distance_to_cusp * - Previous commit had incorrect usage of method transformPose based on different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. * - Previous commit had incorrect usage of method transformPose based on different nav2 branch. - Now a placeholder pose, input pose and desired frame id is passed. Signed-off-by: Steven Brills <sbrills@hotmail.com> * Failed lint check due to stray blank line. Removed the blank line * - Modified findVelocitySignChange function to take the transformed plan in robot's frame - Removed need to pass pose to the findVelocitySignChange function * - Modified the test file to reflect change in new parameters that findVelocitySignChange expects. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Corrected call to transformGlobalPoseWrapper method of BasicAPIRPP object. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - transformGlobalPlanWrapper call bug fix Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Updated tests now require frame_id and time_stamp for conversion since transformed plan is to be used. Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * - Missing ; in test method Signed-off-by: Steven Brills <stevenbrills@hotmail.com> * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead Signed-off-by: Steven Brills <stevenbrills@hotmail.com> Co-authored-by: Steven Brills <sbrills@aethon.com> (cherry picked from commit 99bec08)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… frame before returning distance_to_cusp
Basic Info
Description of contribution in a few bullet points
Added a step where the identified cusp pose in the global plan (map frame) is transformed into the robot_pose frame (odom frame) before the distance to cusp is returned.
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: