[WIP] removing rviz plugins from test coverage since its not a production run-time component#1953
Merged
SteveMacenski merged 2 commits intomainfrom Aug 18, 2020
Merged
[WIP] removing rviz plugins from test coverage since its not a production run-time component#1953SteveMacenski merged 2 commits intomainfrom
SteveMacenski merged 2 commits intomainfrom
Conversation
Member
Author
Contributor
|
Ah, little late to the party but I agree here. Haven't been able to find a good way to write tests for the rviz plugins that actually test the functionality and as you said, they won't be used on actual robots. |
Member
Author
|
Awesome, sounds like we're in full agreement then, Ruffin also agrees |
ruffsl
pushed a commit
to ruffsl/navigation2
that referenced
this pull request
Jul 2, 2021
…tion run-time component (ros-navigation#1953) * removing rviz plugins from test coverage since its not a production run-time component * Update code_coverage_report.bash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1810
We exclude navigation system tests because they're not run-time tools use on someone's robot during an actual use. The rviz plugins are a similar analog, only used for entry level testing, not used when actually on someone's robot for use. We should consider if it makes sense to exclude this as well.
CC @naiveHobo - thoughts?