add note that full source build with ROS 2 rolling could occasionally…#883
Merged
SteveMacenski merged 2 commits intoros-navigation:masterfrom Feb 25, 2026
Merged
Conversation
… fail. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Feb 25, 2026
Contributor
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@pum1k @mini-1235 @SteveMacenski what do you think?
mini-1235
approved these changes
Feb 25, 2026
Collaborator
mini-1235
left a comment
mini-1235
left a comment
There was a problem hiding this comment.
Makes sense to me. Maintaining both approaches would likely be a significant burden, since we would have to add preprocessor conditions everywhere and later remove them, doubling the maintenance effort
For cases like ros-navigation/navigation2#5982, I think we could probably remove that portion of the code to get things building again. However, for certain API/ABI changes, that won't always be possible.
SteveMacenski
approved these changes
Feb 25, 2026
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
A CTA seems nice :-)
Then can merge
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… fail.
closes ros-navigation/navigation2#5982
Basic Info
Description of contribution in a few bullet points