Skip to content

fix travis: format_map is python 3.2 or later only and ignore new rule W504 #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjwwood merged 2 commits into from
Nov 1, 2018
Merged

fix travis: format_map is python 3.2 or later only and ignore new rule W504 #636

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
434d30c
format_map is python 3.2 or later only (see also #602)
NikolausDemmel Oct 27, 2018
2358896
Ignore new pycodestyle rule W504
NikolausDemmel Oct 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/test_flake8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ def test_flake8():
'F841', # ignore presence of unused variables
'I', # ignore import order related warnings
'N802', # ignore presence of upper case in function names
'W504', # ignore line breaks after binary operator (new rule added in 2018)
],
max_line_length=200,
max_complexity=10,
Expand All @@ -53,7 +54,7 @@ def test_flake8():
report._application.formatter.show_statistics(report._stats)
print(
'flake8 reported {report.total_errors} errors'
.format_map(locals()), file=sys.stderr)
.format(**locals()), file=sys.stderr)

assert not report.total_errors, \
'flake8 reported {report.total_errors} errors'.format(**locals())