Skip to content

Bump action-ros-ci to v0.2#165

Closed
matthew-reynolds wants to merge 1 commit intoros-controls:masterfrom
matthew-reynolds:bump_ci_version
Closed

Bump action-ros-ci to v0.2#165
matthew-reynolds wants to merge 1 commit intoros-controls:masterfrom
matthew-reynolds:bump_ci_version

Conversation

@matthew-reynolds
Copy link
Copy Markdown
Member

@matthew-reynolds matthew-reynolds commented Apr 5, 2021

Purpose

Bump ros-tooling/action-ros-ci to v0.2

Summary

Looks like the recent release of ros-tooling/setup-ros v0.1.3 pulled in a newer version of colcon-mixin, which elevated a warning to an error: ros-tooling/action-ros-ci#525 (comment)

This causes ros-tooling/action-ros-ci to fail out. The easiest approach is to just switch to the recently-released v0.2 and update our mixin rules according to ros-tooling/action-ros-ci#591

Testing To Do

  • CI passes
  • Code coverage still works

@matthew-reynolds
Copy link
Copy Markdown
Member Author

matthew-reynolds commented Apr 5, 2021

And of course, CI fails here without #164 due to flakey JTC tests 🤦‍♂️

We should be able to just rerun the CI on this PR to get it to pass though. I don't have permissions to rerun the job, can a maintainer rerun it?

@matthew-reynolds matthew-reynolds mentioned this pull request Apr 5, 2021
@bmagyar
Copy link
Copy Markdown
Member

bmagyar commented May 7, 2021

I'll close this for now, @matthew-reynolds feel free to reopen when a good reason to move presents itself.

@bmagyar bmagyar closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants