Avoid std::stringstream#391
Merged
Karsten1987 merged 1 commit intoros-controls:masterfrom Apr 24, 2021
Merged
Conversation
Member
Author
Contributor
Contributor
|
This builds without errors on rolling. There are some deprecation warnings but for now I'm just trying to get everything building as a start. Thank you for pinging me. |
Contributor
|
If you'd like I can make a PR to add rolling to your CI. Since you are using industrial_ci it is trivial to test building and testing on rolling also. |
Karsten1987
approved these changes
Apr 23, 2021
Contributor
Karsten1987
left a comment
Karsten1987
left a comment
There was a problem hiding this comment.
I personally don't think stringstream introduces a big performance hit, but I am ok with the change - not at least for consistency.
@matthew-reynolds do you have merge rights?
Member
Author
|
Fair enough 👍 Agreed that performance aside, consistency is still a good enough reason for this :) No, I don't have merge rights. |
destogl
added a commit
to b-robotized-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
* Fix correct_initialization_using_parameters * Fix configure_state_ignores_command * Re-enable incorrect_initialization_using_interface_parameters * Re-enable cleanup and activate tests * Port gtest to gmock Co-authored-by: Denis Štogl <denis@stogl.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by seeing #389. We use the stringstream variants of the RCLCPP logging macros so infrequently, we might as well just move away from them entirely and avoid the performance & memory hit associated with
std::stringstream.There are now no longer any
_STREAMs in this repo.Even though
joint_limits_interfaceisn't currently enabled, making the change there means one less thing to worry about if/when that package is eventually enabled or the code is merged into other packages as was suggested.(For context on #389 and this PR: See ros2/rclcpp#1442 or https://docs.ros.org/en/foxy/Releases/Release-Galactic-Geochelone.html#change-in-rclcpp-s-logging-macros for why these RCLCPP macros changed since Foxy)