Add virtual modifier to the functions of Joint and Sensor component#178
Merged
bmagyar merged 4 commits intoros-controls:masterfrom Oct 3, 2020
Merged
Conversation
destogl
changed the title
bmagyar
requested changes
Oct 3, 2020
bmagyar
approved these changes
Oct 3, 2020
Member
bmagyar
left a comment
bmagyar
left a comment
There was a problem hiding this comment.
If the CI is happy, I'm happy
Member
Author
|
Thanks for fixing! |
destogl
pushed a commit
to b-robotized-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
* Set C++ version to C++14 to fix macOS build * Update joint_state_controller/CMakeLists.txt Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com> * Update joint_state_controller/CMakeLists.txt Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds virtual modifier I forgot to in the initial components PR.
constmodifier to theget_command_interfaces()function for the Sensor componentThe issue is referenced in this comment by @Karsten1987 and I had to do the same changes in #147.