Adjust controller_manager library destination#177
Closed
bmagyar wants to merge 1 commit intoros-controls:masterfrom
Closed
Adjust controller_manager library destination#177bmagyar wants to merge 1 commit intoros-controls:masterfrom
bmagyar wants to merge 1 commit intoros-controls:masterfrom
Conversation
Member
|
with this changes I get the following error: The PR is related to #172 |
Contributor
|
I don't think there's anything to change here. The install directory is correct for this target. |
Member
|
And what about export? Should we there prefix ${PROJECT_NAME}? |
Contributor
starting with Foxy, we can rely on modern cmake within ament. I wouldn't bother with this right now and could see this as a follow up PR which addresses this altogether on all repositories. |
Member
Author
|
agreed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.