make gh actions on pair with ros2_controllers#159
Conversation
|
I would to have three jobs:
|
What would be the difference between main and testing? I would assume that main would regularly fail due to synchronization delays. |
|
Let's do 1-2 and discuss 3 when we are done with the foxy release? |
|
can I merge then? |
Main give a test against released packages. Usually useful when developing only on one package. This is not only important for PRs, but also daily builds to see upcoming errors.... |
Not sure I understand this. The way I see this is that "testing" is using the ROS2 testing apt-repo, whereas main refers to the synced one. That being said, I don't see a point to test towards "main", as this is not anything we control, but rather whenever the ROS boss triggers a sync from testing to main. |
|
I can tell from experience that it's important to test against both. Ideally you'd want to compile all green against If the failure happens the other way, it means that someone broke something they probably shouldn't have, you can either adapt to fix (typically happens with dependency chains) or flag it up (API mishap). |
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
9daca4f to
fd088ad
Compare
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
connected to ros-controls/ros2_controllers#98