Skip to content

make gh actions on pair with ros2_controllers#159

Merged
Karsten1987 merged 8 commits intomasterfrom
gh_actions_focal
Sep 26, 2020
Merged

make gh actions on pair with ros2_controllers#159
Karsten1987 merged 8 commits intomasterfrom
gh_actions_focal

Conversation

@Karsten1987
Copy link
Copy Markdown
Contributor

@Karsten1987 Karsten1987 requested a review from bmagyar September 23, 2020 01:36
@destogl
Copy link
Copy Markdown
Member

destogl commented Sep 24, 2020

I would to have three jobs:

  1. industrial_ci with main
  2. industrial_ci with testing
  3. ros_tooling for source build

@Karsten1987
Copy link
Copy Markdown
Contributor Author

industrial_ci with main

What would be the difference between main and testing? I would assume that main would regularly fail due to synchronization delays.

@bmagyar
Copy link
Copy Markdown
Member

bmagyar commented Sep 24, 2020

Let's do 1-2 and discuss 3 when we are done with the foxy release?

@Karsten1987
Copy link
Copy Markdown
Contributor Author

can I merge then?

@destogl
Copy link
Copy Markdown
Member

destogl commented Sep 24, 2020

industrial_ci with main

What would be the difference between main and testing? I would assume that main would regularly fail due to synchronization delays.

Main give a test against released packages. Usually useful when developing only on one package.
Testing shows you the status in advance.

This is not only important for PRs, but also daily builds to see upcoming errors....

@Karsten1987
Copy link
Copy Markdown
Contributor Author

Main give a test against released packages. Usually useful when developing only on one package.
Testing shows you the status in advance.

Not sure I understand this. The way I see this is that "testing" is using the ROS2 testing apt-repo, whereas main refers to the synced one. That being said, I don't see a point to test towards "main", as this is not anything we control, but rather whenever the ROS boss triggers a sync from testing to main.

@bmagyar
Copy link
Copy Markdown
Member

bmagyar commented Sep 25, 2020

I can tell from experience that it's important to test against both.

Ideally you'd want to compile all green against main, but sometimes you may be out of sync and require stuff from testing for everything to work. There's a typical 2-week delay between the two which can be bridged by having both in the CI.

If the failure happens the other way, it means that someone broke something they probably shouldn't have, you can either adapt to fix (typically happens with dependency chains) or flag it up (API mishap).

Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@Karsten1987
Copy link
Copy Markdown
Contributor Author

@destogl @bmagyar please review.

Copy link
Copy Markdown
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmagyar If the ros-tooling makes problems in the future, we can also use industrial_ci for source builds.

Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
@Karsten1987 Karsten1987 merged commit cf63fde into master Sep 26, 2020
@Karsten1987 Karsten1987 deleted the gh_actions_focal branch September 26, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants