Merged
Conversation
Karsten1987
force-pushed
the
gh_actions_focal
branch
2 times, most recently
from
c252eda to
726d5b5
Compare
Karsten1987
changed the title
Karsten1987
force-pushed
the
gh_actions_focal
branch
from
197e100 to
1310ebc
Compare
bmagyar
approved these changes
Sep 24, 2020
bmagyar
requested changes
Sep 24, 2020
Member
bmagyar
left a comment
bmagyar
left a comment
There was a problem hiding this comment.
This PR is a big of a misnomer. The title suggests a fix which was done but you also disabled the industrial_ci job and codecov. Care to detail?
Member
|
See my comment in ros-controls/ROS2-control#159 |
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
This reverts commit 8371698.
Karsten1987
force-pushed
the
gh_actions_focal
branch
from
6d9f08d to
12e9cab
Compare
Contributor
Author
|
I reverted the conditional given that we target only Foxy. Also adopted the description of the PR |
Karsten1987
changed the title
Contributor
Author
destogl
approved these changes
Sep 26, 2020
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
gwalck
pushed a commit
to b-robotized-forks/ros2_controllers
that referenced
this pull request
Jun 7, 2023
* Rename get_controller to get_controllers * Restore get_loaded_controller and add deprecation warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out this was not a CI misconfiguration.ros2/rclcpp#1311 introduced an API break how callbacks for action goals are handled. Given that this (so far) only affects a single test, I don't see an immediate need for branching off and fixed the tests with a simple conditional given the version ofrclcpp.Adapt GH actions: