accessing hardware resources through controller interface#27
Merged
Karsten1987 merged 6 commits intomasterfrom Oct 22, 2020
Merged
accessing hardware resources through controller interface#27Karsten1987 merged 6 commits intomasterfrom
Karsten1987 merged 6 commits intomasterfrom
Conversation
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
bmagyar
requested changes
Oct 17, 2020
destogl
requested changes
Oct 18, 2020
Member
destogl
left a comment
destogl
left a comment
There was a problem hiding this comment.
Very nice work!
I mostly propose simplification of some sentences to provide straightforward guidelines.
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
bmagyar
approved these changes
Oct 20, 2020
Member
bmagyar
left a comment
bmagyar
left a comment
There was a problem hiding this comment.
There are some outstanding points but I think this is mergeable nevertheless.
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
destogl
reviewed
Oct 21, 2020
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
Karsten1987
commented
Oct 22, 2020
Contributor
Author
|
With both reviews approved, going ahead and merge. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karsten Knese Karsten1987@users.noreply.github.com