Remove FunctionScope and improve type tracking #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
commented
Dec 18, 2020
elsassph
reviewed
Dec 18, 2020
|
So the scope of this PR kinda spiraled out of control a bit, but I think for the better. I did still fix the
This change yielded some fairly impressive performance improvements for the @elsassph I'm ready for your review again. |
elsassph
reviewed
Jan 14, 2021
TwitchBronBron
changed the title
TwitchBronBron
force-pushed
the
for-each-var-completions
branch
from
a30d89c to
f2dc8f0
Compare
|
Is this ready for reviewing? If so I might be interested in hopping on a call for this one due to the scope and size. |
|
No, this isn't ready for reviewing yet. I still need to refactor some of typing stuff to look into scopes rather than just per-file. |
* Ran npm audit and fixed vulvnerability * Added symbol table class * Parser adds to a symbol table as it parses code * Revert package changes * Fixed test that was referencing LazyType when it was not supposed to * Better handling of a variable potentially changing type. Added getSymbolType() function and fixed error of a function inheriting symbols from a containing function * Fixed typo * Removed code comment * Fixes from PR comments - and made sure for each loop variables were added to the symbolTable * Changed BscSymbol interface to include a range Co-authored-by: Mark Pearce <[email protected]>
* Adds SymbolTable.hasKey method * Makes CustomType display its actual type * Standardize how a FunctionType is created from an expression * Adds symbol tables to namespaces * Adds a symbol table to scope, and computes merged symbol tables across files * Use the symbolTable on getHover * Working on argument type mismatch validation * Proper type tracking across files in the same scope, including namespaces. Adds validation on argument types * Fixed bad whitespace in tests * Updates from code review * Fixed all circular dependency issues * Hopefully fixed all whitespace issues * Fixes for when scope changes * Fixed lint error and remove symbolTable clear - it was not needed * Clean up getHover code Co-authored-by: Mark Pearce <[email protected]>
|
Closing in favor of the v1 PR #401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable defined in
for eachstatements were not showing up for completions. This PR fixes that.