Feature/symbol table #380
Merged
Feature/symbol table #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bolType() function and fixed error of a function inheriting symbols from a containing function
TwitchBronBron
requested changes
Mar 31, 2021
…dded to the symbolTable
|
Not sure why the mac build failed? I assume some sort of external issue - I have a Mac, and it builds/lints/runs fine on my machine |
The GitHub actions mac builds sometimes have issues. I re-ran them and everything is passing now. |
|
This is a great step forward! Per our conversations in slack, we still have a few scope-related changes to make before the target PR can be merged. However, I'm happy with the current progress of this PR so I'm merging it. |
TwitchBronBron
added a commit
that referenced
this pull request
May 3, 2021
* Add `for each` variable to completions * ForEachStatement's `item` is now VaribleExpression * Fix ts build issue. * fix broken tests * fix broken test. * Collection function variables in _references * Removed FunctionScope in favor of func expressions * lint and interface fixes * Repopulate `references.localVars` during `findReferences` * Handle sub with explicit return type * Fix `findReferences` for local vars * Normalize line endings for Scope.ts * Feature/symbol table (#380) * Ran npm audit and fixed vulvnerability * Added symbol table class * Parser adds to a symbol table as it parses code * Revert package changes * Fixed test that was referencing LazyType when it was not supposed to * Better handling of a variable potentially changing type. Added getSymbolType() function and fixed error of a function inheriting symbols from a containing function * Fixed typo * Removed code comment * Fixes from PR comments - and made sure for each loop variables were added to the symbolTable * Changed BscSymbol interface to include a range Co-authored-by: Mark Pearce <[email protected]> * Feature/scope tracked symbol tables (#395) * Adds SymbolTable.hasKey method * Makes CustomType display its actual type * Standardize how a FunctionType is created from an expression * Adds symbol tables to namespaces * Adds a symbol table to scope, and computes merged symbol tables across files * Use the symbolTable on getHover * Working on argument type mismatch validation * Proper type tracking across files in the same scope, including namespaces. Adds validation on argument types * Fixed bad whitespace in tests * Updates from code review * Fixed all circular dependency issues * Hopefully fixed all whitespace issues * Fixes for when scope changes * Fixed lint error and remove symbolTable clear - it was not needed * Clean up getHover code Co-authored-by: Mark Pearce <[email protected]> * del `references.localVars` in favor of SymbolTable * Move private _symbolTable below the getter Co-authored-by: Mark Pearce <[email protected]> Co-authored-by: Mark Pearce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
SymbolTableclass, and builds the symbol table from assignments and function names