ForEach item completions #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop item in
for eachstatements is not currently showing up in completions. this pr attempted to fix that, but it quickly morphed into an entirely different type of PR.This PR fixes the original issue. I did use the
walkfunction, but only forWalkMode.VisitStatements. The local benchmarks show that the walk doesn't have any significant impact on performance (and remember these numbers are ops/sec for parsing the Roku-GooglePhotos project) :Once #258 lands, the code in this PR will be obsolete, but this helps bridge the gap in the short-term.