Switch back to mainline redis-session-store gem#5877
Merged
zachmargolis merged 2 commits intomainfrom Jan 31, 2022
Merged
Conversation
zachmargolis
commented
Jan 29, 2022
Add PR number
aduth
approved these changes
Jan 31, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM, based on a diff of the two repositories appearing largely the same 👍
Will we plan to archive the forked repository as well?
mitchellhenke
approved these changes
Jan 31, 2022
Contributor
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
👍🏼
There may be a re-fork in the future pending our session race-condition management
Contributor
Author
I have some ideas about race condition management that basically amount to adding a proxy around the adapter, so hopefully no forking needed 🤞 |
Contributor
Author
Yup, I'll go archive it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security patch we had in our fork was merged & released! roidrage/redis-session-store#125