Deploy to Cachix even for PR from forks.#86
Merged
Conversation
Apply the changes from rocq-community/templates#100.
Member
Author
|
Tested at #84. |
palmskog
approved these changes
Sep 3, 2021
Member
palmskog
left a comment
palmskog
left a comment
There was a problem hiding this comment.
Looks good to me in the CI logs.
However, I'm always a bit mystified that all Nix builds seem to have this log message multiple times:
Error: Cannot find plugins directory
It seems harmless and to never affect the build, though.
Member
Author
|
Thanks for reporting, I'll look into it. |
Member
|
If it helps, here's a fresh example from a non-plugin project: https://github.com/coq-community/huffman/pull/30/checks?check_run_id=3508651515#step:8:384 |
Member
Author
|
OK, the reason was that some version comparison logic mistake made it so that we were using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the changes from rocq-community/templates#100.