Skip to content

Test a new setup to deploy to Cachix even for PR from forks.#84

Closed
Zimmi48 wants to merge 1 commit intorocq-community:pull-request-targetfrom
Zimmi48:test-branch
Closed

Test a new setup to deploy to Cachix even for PR from forks.#84
Zimmi48 wants to merge 1 commit intorocq-community:pull-request-targetfrom
Zimmi48:test-branch

Conversation

@Zimmi48
Copy link
Copy Markdown
Member

@Zimmi48 Zimmi48 commented Aug 9, 2021

The explanation can be found in the commit pushed to the pull-request-target branch:

Use the pull_request_target event instead of the pull_request event to deploy to have access to secret environment variables in all cases. We now skip the actions/checkout@v2 step because it wouldn't check out the correct commit. This is safe (no risk of linking the secret variables) even with untrusted code because nix-build will build it in an isolated environment.

I'm opening this fake PR to test the behavior it gives for a PR from a fork (does it report a CI status like it would for a pull_request event? EDIT: yes, it does, with a slightly different name).

@Zimmi48
Copy link
Copy Markdown
Member Author

Zimmi48 commented Aug 9, 2021

Closing / reopening to hopefully trigger a workflow using the updated version in the base ref (that should now test the automatically created merge commit instead of the head of the PR).

@Zimmi48 Zimmi48 closed this Aug 9, 2021
@Zimmi48 Zimmi48 reopened this Aug 9, 2021
@Zimmi48 Zimmi48 closed this Aug 9, 2021
@Zimmi48 Zimmi48 reopened this Aug 9, 2021
@Zimmi48 Zimmi48 closed this Aug 9, 2021
@Zimmi48 Zimmi48 reopened this Aug 9, 2021
@Zimmi48
Copy link
Copy Markdown
Member Author

Zimmi48 commented Aug 9, 2021

Testing was conclusive. This PR can be closed.

@Zimmi48 Zimmi48 closed this Aug 9, 2021
@Zimmi48 Zimmi48 deleted the test-branch branch August 9, 2021 16:06
@Zimmi48 Zimmi48 restored the test-branch branch August 9, 2021 17:24
@Zimmi48
Copy link
Copy Markdown
Member Author

Zimmi48 commented Aug 9, 2021

Testing one last configuration.

@Zimmi48 Zimmi48 reopened this Aug 9, 2021
@Zimmi48 Zimmi48 closed this Aug 9, 2021
@palmskog
Copy link
Copy Markdown
Member

@Zimmi48 should we keep the pull-request-target branch around? Or can we delete it?

@Zimmi48
Copy link
Copy Markdown
Member Author

Zimmi48 commented Aug 23, 2021

Let's delete it until the corresponding PR on the templates repository is updated (which I won't do before the corresponding PR on the Coq Nix Toolbox repository is merged).

@Zimmi48 Zimmi48 deleted the test-branch branch August 23, 2021 16:40
@Zimmi48 Zimmi48 restored the test-branch branch August 31, 2021 18:59
@Zimmi48 Zimmi48 reopened this Aug 31, 2021
@Zimmi48
Copy link
Copy Markdown
Member Author

Zimmi48 commented Aug 31, 2021

Tested to work when PR has conflicts (tests pull/XX/head) and no conflicts (tests pull/XX/merge).

@Zimmi48 Zimmi48 closed this Aug 31, 2021
@Zimmi48 Zimmi48 deleted the test-branch branch October 26, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants