Skip to content

mkCoqDerivation: use COQMF_COQLIB for dev versions of Coq#136908

Merged
vbgl merged 1 commit intoNixOS:masterfrom
Zimmi48:coqmf-prefix-dev
Sep 8, 2021
Merged

mkCoqDerivation: use COQMF_COQLIB for dev versions of Coq#136908
vbgl merged 1 commit intoNixOS:masterfrom
Zimmi48:coqmf-prefix-dev

Conversation

@Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Sep 6, 2021

Motivation for this change

Minor fix. The use of COQLIB for newer versions of Coq (including dev versions) is improper and would trigger several Error: Cannot find plugins directory messages in the build logs.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Zimmi48 Zimmi48 requested review from siraben and vbgl September 6, 2021 15:05
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 6, 2021
@vbgl vbgl merged commit 7136060 into NixOS:master Sep 8, 2021
@Zimmi48 Zimmi48 deleted the coqmf-prefix-dev branch September 8, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants