D alex #37
D alex #37
Conversation
| @@ -198,7 +198,11 @@ def run(action_interface, arguments = Hash.new) | |||
| if !arguments.empty? | |||
| raise ArgumentError, "#{name} expects no arguments, but #{arguments.size} are given" | |||
| end | |||
| result = action_interface.send(name).as_plan | |||
| result = action_interface.send(name) | |||
| if(!result.class.has_ancestor?(returned_type)) | |||
There was a problem hiding this comment.
Actually, the #as_plan is really needed as e.g. syskit returns an object that's not a task (but object#as_plan turns it into one).
Why don't you check on the result of #as_plan ?
D-Alex
force-pushed
the
d-alex
branch
2 times, most recently
from
da9c01a
to
495fb8b
Compare
|
A note on the commit prefixes: I use only a few: core: for all in lib/roby/ and lib/roby/models/ Moreover, I prefer that you squash test and fix in the same commit. |
at the moment the follwoing code produces an error which is not
really addressing the issue
Robot.actions do
describe('move robot')
def move(arg)
Roby::Task.new
end
end
--> invalid replacement: missing provided models
Roby2::Actions::Main::Move
Delayed blocks were not removed from the execution engine after they got called.
The ActionStateMachine is using a similar API as ActionScript. In the first case, the start method sets the start state for the state machine and does not start anything. Therefore, to prevent an misunderstanding an exception is added in case start is called multiple times.
In case of a TimedOut exception the hole syskit instance is terminated. To help understanding how this can be prevented the error message is extended.
see #timeout_start implementation.
|
Ok, I rebased everything and removed some of the commits which are obviously not going to be merged. The open issues are:
I can create an issue for this, if you like. |
|
Also: the tests don't pass The best way to develop & test on Roby is to have a separate checkout and then do |
|
(and Roby has travis integration enabled ... your PR is being checked right into github !) |
|
I've moved the return type discussion to a separate issue: #46 |
I probably using Roby a bit differently and run into some problems. The following commits improve my workflow but I am not sure how they fit into a bigger picture.