Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: the generated return task model for actions is confusing #46

Open
doudou opened this issue Dec 10, 2015 · 0 comments
Open

actions: the generated return task model for actions is confusing #46

doudou opened this issue Dec 10, 2015 · 0 comments

Comments

@doudou
Copy link
Member

doudou commented Dec 10, 2015

Follow-up of the discussion in #37

Currently, Roby generates a specific task model for all actions. It is necessary for action coordination objects (scripts and actions) as the system designer rarely touches the toplevel task. For handwritten actions, it is plain confusing.

So, I would move to have the default returns be Roby::Task for "manual" actions, and use an automatically generated task model only for action scripts/action state machines.

In addition, we should validate that the value returned by an action is not abstract UNLESS it is specified (i.e. add a returns_abstract statement in the action definition). The vast majority of cases will NOT want an abstract task as root.

@doudou doudou mentioned this issue Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant