Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of PR #349 for problem related to POS service #356

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Mar 8, 2023

This PR introduces a dummy function for the method eo_pos_isAlive when the POS service is disabled in a board.
This has been done in order to fix compilation problem for projects that do not used POS service introduced with the PR #349 where a file shared among projects has been modified.

@MSECode
Copy link
Contributor Author

MSECode commented Mar 8, 2023

cc: @valegagge @sgiraz @marcoaccame

@pattacini pattacini requested a review from marcoaccame March 8, 2023 09:56
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks

@marcoaccame marcoaccame self-requested a review March 8, 2023 12:33
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@marcoaccame marcoaccame merged commit b469e15 into robotology:devel Mar 8, 2023
mfussi66 pushed a commit to mfussi66/icub-firmware that referenced this pull request Mar 27, 2023
@MSECode MSECode deleted the fix/servicePOS branch May 3, 2023 08:45
valegagge pushed a commit to valegagge/icub-firmware that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants