Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved calib type 6 w/ FAP. #349

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Improved calib type 6 w/ FAP. #349

merged 3 commits into from
Mar 3, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Feb 28, 2023

Tested and working on both desk setup and ergocab robot.

In this PR the following tasks have been done:

  • Improve current working calibration type 6 by allowing to use FAP sensors instead of MICE;
  • Tested the calibration procedure on the left arm bench setup.
  • Tested the calibration procedure on the left arm of ergocub robot (test on right arm is going to be done)
  • Updated firmware code by customizing calibration type 6 enabling POS service use

@valegagge valegagge requested a review from marcoaccame March 1, 2023 08:26
@marcoaccame marcoaccame self-assigned this Mar 2, 2023
@marcoaccame
Copy link
Contributor

Hi @MSECode, welcome to your first PR in robotology/icub-firmware. I will have a look at it later today.

marcoaccame
marcoaccame requested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is fine. I assume it was tested on the robot.
I have just noted the snprintf but they are very minor things.

Thanks for your contribution.

emBODY/eBcode/arch-arm/embobj/plus/mc/Calibrators.c Outdated Show resolved Hide resolved
emBODY/eBcode/arch-arm/embobj/plus/mc/Calibrators.c Outdated Show resolved Hide resolved
emBODY/eBcode/arch-arm/embobj/plus/mc/Calibrators.c Outdated Show resolved Hide resolved
emBODY/eBcode/arch-arm/embobj/plus/mc/JointSet.c Outdated Show resolved Hide resolved
@marcoaccame
Copy link
Contributor

Companion PR is:

@MSECode
Copy link
Contributor Author

MSECode commented Mar 3, 2023

Submitted changes in commit

@marcoaccame marcoaccame merged commit 02cc91f into robotology:devel Mar 3, 2023
@MSECode MSECode mentioned this pull request Mar 8, 2023
Merged
marcoaccame pushed a commit that referenced this pull request Mar 8, 2023
@MSECode
Fix of PR #349 for problem related to POS service (#356)
b469e15
mfussi66 pushed a commit to mfussi66/icub-firmware that referenced this pull request Mar 27, 2023
@MSECode @mfussi66
Fix of PR robotology#349 for problem related to POS service (robotolo…
76f9a38 
…gy#356)
valegagge added a commit to valegagge/icub-firmware that referenced this pull request May 5, 2023
@MSECode @valegagge
Improved calib type 6 w/ FAP. (robotology#349)
612dfb7 
Co-authored-by: Valentina Gaggero <[email protected]>
valegagge pushed a commit to valegagge/icub-firmware that referenced this pull request May 5, 2023
@MSECode @valegagge
Fix of PR robotology#349 for problem related to POS service (robotolo…
4c0ecb0 
…gy#356)
@valegagge valegagge deleted the ecubfingercalib branch June 28, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

Assignees

@marcoaccame marcoaccame

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSECode @marcoaccame @valegagge