Skip to content

add forwardRef to withTheme#1498

Merged
epicfaace merged 6 commits intorjsf-team:masterfrom
zepatrik:withTheme-forward-ref
Jan 11, 2020
Merged

add forwardRef to withTheme#1498
epicfaace merged 6 commits intorjsf-team:masterfrom
zepatrik:withTheme-forward-ref

Conversation

@zepatrik
Copy link
Contributor

Reasons for making this change

fixes #1405
I didn't update the docs because I would assume this is actually default behavior.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@epicfaace epicfaace self-assigned this Nov 9, 2019
@epicfaace
Copy link
Member

@zepatrik ?

Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
@delyanr delyanr mentioned this pull request Dec 29, 2019
11 tasks
ref,
});

expect(ref.current.submit).not.eql(undefined);;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expect(ref.current.submit).not.eql(undefined);;
expect(ref.current.submit).not.eql(undefined);

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was hesitant to merge until I could find out why you had to create a WrapperClassComponent for testing. It appears that it's because of the testing library we're using and it might require a refactoring of the testing framework we use in the first place, so this is good to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withTheme does not forward ref

2 participants