fix(react-jsonschema-form): withTheme forwards the ref to the form#46102
fix(react-jsonschema-form): withTheme forwards the ref to the form#46102zepatrik wants to merge 2 commits intoDefinitelyTyped:masterfrom
Conversation
As someone noted (here)[rjsf-team/react-jsonschema-form#1405 (comment)] the current typing does not reflect the forwarding of the ref to the form component.
|
@zepatrik Thank you for submitting this PR! This is a live comment which I will keep updated. Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 46102,
"author": "zepatrik",
"owners": [
"iamdanfox",
"iplus26",
"phbou72",
"LucianBuzzo",
"sthenault",
"sbusch",
"medfreeman",
"saadtazi",
"agustin107",
"chanceaclark",
"ogdentrod",
"andrenguyener",
"qingqishi"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "0d6ce1f",
"headCommitOid": "0d6ce1fd9e80c4aef4a01eb2989d29d8bb10b795",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastPushDate": "2020-07-15T11:14:20.000Z",
"lastCommentDate": "2020-07-15T11:14:20.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46102/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": false,
"packages": [
"react-jsonschema-form"
],
"files": [
{
"path": "types/react-jsonschema-form/index.d.ts",
"kind": "definition",
"package": "react-jsonschema-form"
},
{
"path": "types/react-jsonschema-form/react-jsonschema-form-tests.tsx",
"kind": "test",
"package": "react-jsonschema-form"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-07-16T15:57:55.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
|
🔔 @iamdanfox @iplus26 @phbou72 @LucianBuzzo @sthenault @sbusch @medfreeman @saadtazi @agustin107 @chanceaclark @ogdentrod @andrenguyener @QingqiShi — please review this PR in the next few days. Be sure to explicitly select |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
|
Actually the package starting with v2+ has it's own type definitions and is published as |
As someone noted here the current typing does not reflect the forwarding of the ref to the form component.
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present and it shouldn't have any additional or disabling of rules. Just content as{ "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.If removing a declaration:
notNeededPackages.json.