Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions packages/core/src/withTheme.js
Original file line number Diff line number Diff line change
@@ -1,23 +1,22 @@
import React, { Component } from "react";
import React, { forwardRef } from "react";
import PropTypes from "prop-types";
import Form from "./";

function withTheme(themeProps) {
return class extends Component {
render() {
let { fields, widgets, ...directProps } = this.props;
fields = { ...themeProps.fields, ...fields };
widgets = { ...themeProps.widgets, ...widgets };
return (
<Form
{...themeProps}
{...directProps}
fields={fields}
widgets={widgets}
/>
);
}
};
return forwardRef(({ fields, widgets, ...directProps }, ref) => {
fields = { ...themeProps.fields, ...fields };
widgets = { ...themeProps.widgets, ...widgets };

return (
<Form
{...themeProps}
{...directProps}
fields={fields}
widgets={widgets}
ref={ref}
/>
);
});
}

withTheme.propTypes = {
Expand Down
103 changes: 72 additions & 31 deletions packages/core/test/withTheme_test.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
import { expect } from "chai";
import React from "react";
import React, { Component, createRef } from "react";

import { withTheme } from "../src";
import { createComponent, createSandbox } from "./test_utils";

const WrapperClassComponent = (...args) => {
return class extends Component {
render() {
const Cmp = withTheme(...args);
return <Cmp {...this.props} />;
}
};
};

describe("withTheme", () => {
let sandbox;

Expand Down Expand Up @@ -34,7 +43,7 @@ describe("withTheme", () => {
},
};
const uiSchema = {};
let { node } = createComponent(withTheme({ fields }), {
let { node } = createComponent(WrapperClassComponent({ fields }), {
schema,
uiSchema,
});
Expand Down Expand Up @@ -64,11 +73,14 @@ describe("withTheme", () => {
},
};
const uiSchema = {};
let { node } = createComponent(withTheme({ fields: themeFields }), {
schema,
uiSchema,
fields: userFields,
});
let { node } = createComponent(
WrapperClassComponent({ fields: themeFields }),
{
schema,
uiSchema,
fields: userFields,
}
);
expect(node.querySelectorAll(".string-field")).to.have.length.of(1);
expect(node.querySelectorAll(".number-field")).to.have.length.of(1);
});
Expand Down Expand Up @@ -96,11 +108,14 @@ describe("withTheme", () => {
},
};
const uiSchema = {};
let { node } = createComponent(withTheme({ fields: themeFields }), {
schema,
uiSchema,
fields: userFields,
});
let { node } = createComponent(
WrapperClassComponent({ fields: themeFields }),
{
schema,
uiSchema,
fields: userFields,
}
);
expect(node.querySelectorAll(".string-field")).to.have.length.of(0);
expect(node.querySelectorAll(".form-control")).to.have.length.of(2);
});
Expand All @@ -115,7 +130,7 @@ describe("withTheme", () => {
type: "string",
};
const uiSchema = {};
let { node } = createComponent(withTheme({ widgets }), {
let { node } = createComponent(WrapperClassComponent({ widgets }), {
schema,
uiSchema,
});
Expand All @@ -142,11 +157,14 @@ describe("withTheme", () => {
},
};
const uiSchema = {};
let { node } = createComponent(withTheme({ widgets: themeWidgets }), {
schema,
uiSchema,
widgets: userWidgets,
});
let { node } = createComponent(
WrapperClassComponent({ widgets: themeWidgets }),
{
schema,
uiSchema,
widgets: userWidgets,
}
);
expect(node.querySelectorAll("#test-theme-widget")).to.have.length.of(1);
expect(node.querySelectorAll("#test-user-widget")).to.have.length.of(1);
});
Expand All @@ -167,11 +185,14 @@ describe("withTheme", () => {
},
};
const uiSchema = {};
let { node } = createComponent(withTheme({ widgets: themeWidgets }), {
schema,
uiSchema,
widgets: userWidgets,
});
let { node } = createComponent(
WrapperClassComponent({ widgets: themeWidgets }),
{
schema,
uiSchema,
widgets: userWidgets,
}
);
expect(node.querySelectorAll("#test-theme-widget")).to.have.length.of(0);
expect(node.querySelectorAll("#test-user-widget")).to.have.length.of(1);
});
Expand All @@ -196,10 +217,13 @@ describe("withTheme", () => {
},
};
const uiSchema = {};
let { node } = createComponent(withTheme({ ...themeTemplates }), {
schema,
uiSchema,
});
let { node } = createComponent(
WrapperClassComponent({ ...themeTemplates }),
{
schema,
uiSchema,
}
);
expect(
node.querySelectorAll(".with-theme-field-template")
).to.have.length.of(1);
Expand All @@ -221,16 +245,33 @@ describe("withTheme", () => {
type: "object",
properties: { foo: { type: "string" }, bar: { type: "string" } },
};
let { node } = createComponent(withTheme({ ...themeTemplates }), {
schema,
...userTemplates,
});
let { node } = createComponent(
WrapperClassComponent({ ...themeTemplates }),
{
schema,
...userTemplates,
}
);
expect(
node.querySelectorAll(".with-theme-field-template")
).to.have.length.of(0);
expect(node.querySelectorAll(".user-field-template")).to.have.length.of(
1
);
});

it("should forward the ref", () => {
const ref = createRef();
const schema = {};
const uiSchema = {};

createComponent(withTheme({}), {
schema,
uiSchema,
ref,
});

expect(ref.current.submit).not.eql(undefined);
});
});
});