-
Notifications
You must be signed in to change notification settings - Fork 21
Update system prompt in the template #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated two duplicate Changes
Sequence Diagram(s)(omitted — changes are strictly prompt text edits, no control-flow or feature changes) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
template.yaml (1)
318-318: Capitalize “OpenShift” and clarify internal tool usage.
Current line uses lowercase “openshift” and could read as user-facing tool instruction, which conflicts with earlier guidance about not mentioning tools. Recommend tightening the phrasing.- * If a step requires specific information (e.g., cluster ID, host ID, VIPs, openshift version), explicitly ask for it, unless you can obtain it from the conversation context or by using a tool. + * If a step requires specific information (e.g., cluster ID, host ID, VIPs, OpenShift version), explicitly ask for it, unless you can obtain it from the conversation context or internally via tools (without referencing them to the user).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
template.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request
🔇 Additional comments (2)
template.yaml (2)
236-236: Persona line aligned with new branding.
Wording is consistent with the earlier identity sentence and tone guidance.
233-233: All “OpenShift Lightspeed” references removed – branding rename completeI ran ripgrep across the repository searching for the old branding terms (“OpenShift Lightspeed”, “OpenShift Lightspeed Intelligent Assistant”, “OSLIA”) and found no occurrences.
No further action needed; the rename to “Red Hat Lightspeed Intelligent Assistant” is fully applied.
Renamed the assistent "Red Hat OpenShift Lightspeed" instead of "OpenShift Lightspeed" Updated the general proactive principles to use tools for getting required information Signed-off-by: Eran Cohen <[email protected]>
0de85c5 to
c07dcb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
template.yaml (1)
318-318: Capitalize OpenShift and clarify tool phrasing to avoid user-facing mentions.Minor wording tweak to align with earlier guideline not to mention tools to users.
- * If a step requires specific information (e.g., cluster ID, host ID, VIPs, openshift version), explicitly ask for it, unless you can obtain it from the conversation context or by using a tool. + * If a step requires specific information (e.g., cluster ID, host ID, VIPs, OpenShift version), explicitly ask for it, unless you can obtain it from the conversation context or via available tools (without mentioning tools to the user).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
template.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request
🔇 Additional comments (2)
template.yaml (2)
233-233: Branding rename looks correct and scoped."Red Hat OpenShift Lightspeed Intelligent Assistant" is consistently applied in the system prompt header.
236-236: Identity line consistent with branding and capitalization.Persona statement matches the new name and uses correct "OpenShift" capitalization.
|
@eranco74: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
Renamed the assistent "Red Hat Lightspeed" instead of "OpenShift Lightspeed"
Updated the general proactive principles to use tools for getting required information
Summary by CodeRabbit
New Features
Style
Documentation