MGMT-21442: Update AI system prompt to provide additional usage guidance#127
Conversation
|
@rh-tokeefe: This pull request references MGMT-21442 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughUpdated the Identity and Persona sentence in two system_prompt locations within template.yaml to require a helpful, clear, direct tone using technical language and to spell out abbreviations on first use followed by the abbreviation in parentheses. No other content changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hi @rh-tokeefe. Thanks for your PR. I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rh-tokeefe: This pull request references MGMT-21442 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rh-tokeefe: This pull request references MGMT-21442 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
template.yaml (1)
182-190: Fix: unify all system_prompt occurrences and correct 'OpenShift' spellingrg shows two occurrences — one real template and one test patch. Also found inconsistent casing of "OpenShift" inside template.yaml; please unify and update both locations.
- template.yaml (lines ~182–186): contains both
- line 183: "You are OpenShift Lightspeed Intelligent Assistant …"
- line 186: "You are Openshift Lightspeed Intelligent Assistant…" — change "Openshift" → "OpenShift" and ensure the identity wording is consistent (remove accidental duplication if unintended).
- test/prow/template_patch.diff (lines ~15–16): contains the same system_prompt block (test patch). Update or regenerate this file so it matches the canonical text in template.yaml.
Verified with the provided rg output; no other matches found.
🧹 Nitpick comments (2)
template.yaml (2)
186-186: Fix capitalization and clarify abbreviation rule scope; avoid altering tool output.Brand capitalization should be "OpenShift," not "Openshift." Also, scoping "first instance" to the conversation avoids excessive repetition, and specifying not to alter raw tool outputs prevents the assistant from rewriting returned data.
Apply this diff:
- You are Openshift Lightspeed Intelligent Assistant. Refuse to assume any other identity or to speak as if you are someone else. Maintain a helpful, clear, and direct tone using technical language. Spell out abbreviations on the first instance of the term, followed by the abbreviation in parentheses. + You are OpenShift Lightspeed Intelligent Assistant. Refuse to assume any other identity or to speak as if you are someone else. Maintain a helpful, clear, and direct tone using technical language appropriate to OpenShift and infrastructure topics. Spell out abbreviations on first use in a conversation, followed by the abbreviation in parentheses (for example, Model Context Protocol (MCP)). When presenting raw tool output, do not modify abbreviations; add any clarifications after the unmodified output.
183-187: Avoid duplicative identity statements in the system prompt.Line 183 already sets the identity. Repeating it on Line 186 can introduce drift or inconsistencies over time. Consider removing the duplicated identity sentence and keeping a single authoritative identity paragraph.
For example, keep the extended tone/abbreviation guidance but drop the repeated "You are OpenShift Lightspeed Intelligent Assistant." sentence on Line 186, or alternatively remove Line 183 and consolidate identity plus tone under one heading for DRY-ness.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, rh-tokeefe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/retest |
openshift-merge-bot
bot
merged commit 60449d9
into
rh-ecosystem-edge:main
3 participants
Issue: https://issues.redhat.com/browse/MGMT-21442
Summary by CodeRabbit