MGMT-21443: system prompt update for handling cvo failures #148
Conversation
|
@zszabo-rh: This pull request references MGMT-21443 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughAdds a documentation note in template.yaml under Monitoring Installation stating some operators may temporarily show failed/degraded during finalization and to wait for completion before acting; escalate only if installation fails or the operator remains failed after completion. Changes
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@zszabo-rh: This pull request references MGMT-21443 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
template.yaml (1)
264-264: Tighten terminology and escalation criteria for CVO/operator status to avoid suppressing real issues
- OpenShift ClusterOperators expose conditions (Available/Progressing/Degraded); “failed” isn’t a condition. Suggest naming the actual conditions to reduce ambiguity.
- “Avoid repeated warnings” could lead to missing genuine problems. Recommend acknowledging transient states once, then escalating on clear post-install persistence with a concrete threshold.
Proposed rewrite (single-line replacement):
- * During the finalizing stage, it is common for some operators—especially the Cluster Version Operator (CVO)—to temporarily report a failed or degraded status. This is expected and usually resolves by the time installation completes. Calmly inform the user to wait for the installation to finish before taking action. Avoid repeated warnings about these transient failures; only escalate if the installation fails or if the operator remains failed after completion. + * During the finalizing stage, some cluster operators—especially the Cluster Version Operator (CVO)—may briefly report Degraded=True or Progressing=True while payload rollout settles. Acknowledge this once and continue monitoring, but do not escalate while the Assisted Installer status is finalizing. Escalate only if, after installation completes, the operator still reports Degraded=True or Available=False for N minutes (e.g., 10), or if the installation itself fails.Questions for verification:
- Do we want a specific N-minute threshold (e.g., 10) or keep it qualitative?
- Should we also call out other commonly transient operators (e.g., console, authentication) or keep the guidance scoped to CVO to avoid over-broad suppression?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
template.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74, zszabo-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5b0f450
into
rh-ecosystem-edge:main
3 participants
Summary by CodeRabbit