Update system prompt#62
Conversation
|
""" WalkthroughThis change deletes the detailed Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant generate.sh
participant template.yaml
participant config/systemprompt.txt
Developer->>generate.sh: Run script
generate.sh->>template.yaml: Read lightspeed-stack-config.data.system_prompt
generate.sh->>config/systemprompt.txt: Write extracted system_prompt
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested labels
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
template.yaml (1)
165-168: Minor grammar tweak for clarity“Cluster with user-managed networking enabled don't need …” → plural agreement.
-* Cluster with user-managed networking enabled don't need to **set API and Ingress VIPs**. +* Clusters with user-managed networking enabled don't need to **set API and Ingress VIPs**.Nit-level, but improves professionalism of the prompt.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.gitignore(1 hunks)config/systemprompt.txt(0 hunks)scripts/generate.sh(1 hunks)template.yaml(2 hunks)
💤 Files with no reviewable changes (1)
- config/systemprompt.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request
🔇 Additional comments (2)
.gitignore (1)
3-3: Entry looks correct – no further action required
/config/systemprompt.txtis now generated at build time and shouldn’t be tracked.
The pattern is scoped to the repository root (leading slash) and won’t ignore similarly-named files elsewhere – good choice.template.yaml (1)
139-143: Prompt addition looks well-formattedIndentation inside the block scalar is correct and the separator line (
---) keeps sections readable.
No structural YAML issues detected.
Signed-off-by: Eran Cohen <eranco@redhat.com>
- Remove all the instructions regarding Memory and Context Retention - Keep Direct Display of List Outputs instruction - Update Cluster Configuration phase with "clusters with user managed networking enabled don't require setting VIPs" (MGMT-21213) Signed-off-by: Eran Cohen <eranco@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, eranco74 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1a080a8
into
rh-ecosystem-edge:main
2 participants
Summary by CodeRabbit
Chores
Documentation