Update egui to latest master by lucasmerlin · Pull Request #9103 · rerun-io/rerun

lucasmerlin · 2025-02-21T08:38:57Z

What

I was curious how my work on egui menus and popups would work in rerun, so I gave it a try.

Findings so far

~~The new tooltip positioning works well unless we scroll in the scroll area. Maybe we should intersect the widget rect with the clip rect.~~ Fixed!

Screen.Recording.2025-02-21.at.09.30.39.mov

github-actions · 2025-02-21T08:39:29Z

Web viewer built successfully. If applicable, you should also test it:

I have tested the web viewer

Result	Commit	Link	Manifest
✅	`c0e5a14`	https://rerun.io/viewer/pr/9103	`+nightly` `+main`

^{Note: This comment is updated whenever you push a commit.}

In Rerun, pressing `Cmd+S` brings up a save dialog using `rfd`, but we get not key-up event for the `S` key (in winit). This leads to `S` being mistakenly marked as down when we switch back to the app. This PR takes the safe route and marks all keys as up when an egui app loses focus. * Tested with rerun-io/rerun#9103

lucasmerlin · 2025-02-28T09:00:43Z

~~This seems to break resizing of panels, probably an egui bug?~~

Fixed!

lucasmerlin · 2025-03-13T17:19:32Z

Found a couple more egui bugs:

# Conflicts: # crates/viewer/re_redap_browser/src/add_server_modal.rs # crates/viewer/re_selection_panel/src/view_entity_picker.rs # crates/viewer/re_ui/src/modal.rs # crates/viewer/re_view_dataframe/src/view_query/ui.rs

lucasmerlin · 2025-04-24T12:15:42Z

The image loader now being async makes tests that have images (so basically all rerun tests) flakey 🙁 Maybe Harness::run could somehow check if there are any in-progress images and automatically do the run_realtime thing (where it calls thread::sleep between each frame)?

lucasmerlin · 2025-04-24T12:24:44Z

Also, basically all snapshots containing text have changed. Seems like text is slightly less strong now. Wondering if this was caused by this? emilk/egui#5824

emilk · 2025-04-24T12:43:48Z

Text rendering changed in

Improve text sharpness emilk/egui#5838

So it is expected that all screenshots with text changes.

The text should be more crisp and clear now though

emilk · 2025-04-24T17:27:28Z

The image loader now being async makes tests that have images (so basically all rerun tests) flakey 🙁 Maybe Harness::run could somehow check if there are any in-progress images and automatically do the run_realtime thing (where it calls thread::sleep between each frame)?

Or we disable the background loading in tests, somehow (making them blocking instead)

emilk

Nice

crates/viewer/re_time_panel/src/time_panel.rs

emilk · 2025-04-30T12:31:11Z

crates/viewer/re_ui/tests/help_ui_test.rs

@@ -59,7 +59,7 @@ fn test_help() {

        harness.get_by_label("❓").hover();

-        harness.run();
+        harness.try_run_realtime().ok();


Why this change?

Snapshot wouldn't include the icons otherwise. Not sure why this is necessary after making images load blockingly in tests, maybe that doesn't work as expected 🤔

lucasmerlin · 2025-04-30T12:51:15Z

Clicking links in egui_commonmark is broken 😔:

Screen.Recording.2025-04-30.at.14.46.56.mov

Edit: Fix: emilk/egui#6905

lucasmerlin · 2025-04-30T15:39:32Z

I've added snapshot_with_broken_pixels which takes a count of broken pixels, with the following benefits over snapshot_with_broken_pixels_threshold

no need to calculate the num_pixels
can directly use the diff value from a failed ci job
if even a single pixel more changes in a future update the test is ensured to fail

# Conflicts: # crates/viewer/re_view_dataframe/src/view_query/ui.rs

crates/viewer/re_viewer_context/src/test_context.rs

# Conflicts: # crates/viewer/re_time_panel/tests/snapshots/focused_item_is_focused.png # crates/viewer/re_time_panel/tests/snapshots/various_entity_kinds_timeline_a_0.png # crates/viewer/re_time_panel/tests/snapshots/various_entity_kinds_timeline_a_5.png # crates/viewer/re_time_panel/tests/snapshots/various_entity_kinds_timeline_a_9223372036854775807.png # crates/viewer/re_time_panel/tests/snapshots/various_entity_kinds_timeline_b_0.png # crates/viewer/re_time_panel/tests/snapshots/various_entity_kinds_timeline_b_5.png # crates/viewer/re_time_panel/tests/snapshots/various_entity_kinds_timeline_b_9223372036854775807.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-_path_to,_rig.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-_to_the.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-_to_the_.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-ath,left.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-ath,t.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-none.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-path.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-t.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-to_the,oid.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-to_the.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-to_the_.png # crates/viewer/re_time_panel/tests/snapshots/various_filters-void.png

crates/viewer/re_time_panel/tests/snapshots/focused_item_is_focused.png

# Conflicts: # crates/viewer/re_selection_panel/src/defaults_ui.rs # crates/viewer/re_selection_panel/src/visualizer_ui.rs # crates/viewer/re_view/src/view_property_ui.rs

### What #9103 broke the notification popup, this is the fix. Seems like `view_space_origin_widget_editing_ui` was also broken, but I'm not sure where that ui is.

In Rerun, pressing `Cmd+S` brings up a save dialog using `rfd`, but we get not key-up event for the `S` key (in winit). This leads to `S` being mistakenly marked as down when we switch back to the app. This PR takes the safe route and marks all keys as up when an egui app loses focus. * Tested with rerun-io/rerun#9103

emilk mentioned this pull request Feb 24, 2025

Mark all keys as up if the app loses focus emilk/egui#5743

Merged

lucasmerlin force-pushed the lucas/egui-popup-modal-update branch from 9b40cb7 to 200768b Compare February 25, 2025 09:33

lucasmerlin force-pushed the lucas/egui-popup-modal-update branch 2 times, most recently from 2ce720e to 7284f6b Compare February 28, 2025 08:54

lucasmerlin added dependencies concerning crates, pip packages etc egui Requires egui/eframe work labels Mar 3, 2025

lucasmerlin added 6 commits March 13, 2025 15:55

Update egui to laters master

7326f46

Update stuff

b996a49

Use egui from master

427f9c9

Use MenuButton instead of SubMenuButton

943ad26

Use new egui close fn and return egui ModalResponse

a48d2be

Replace deprecated fns

98266f5

lucasmerlin force-pushed the lucas/egui-popup-modal-update branch from b52f513 to 98266f5 Compare March 13, 2025 17:18

lucasmerlin added 4 commits April 24, 2025 12:11

Merge branch 'main' into lucas/egui-popup-modal-update

2826898

# Conflicts: # crates/viewer/re_redap_browser/src/add_server_modal.rs # crates/viewer/re_selection_panel/src/view_entity_picker.rs # crates/viewer/re_ui/src/modal.rs # crates/viewer/re_view_dataframe/src/view_query/ui.rs

Replace close_menu calls

0467890

Update egui

dd2a579

Ooof that's a lot of snapshots

7d518ce

lucasmerlin added exclude from changelog PRs with this won't show up in CHANGELOG.md include in changelog and removed include in changelog labels Apr 24, 2025

lucasmerlin added 2 commits April 30, 2025 09:46

Merge branch 'main' into lucas/egui-popup-modal-update

8fa32f7

Use new menu button

0d929b1

lucasmerlin added 2 commits April 30, 2025 14:19

Update threshold

5394d9e

Use rerun commonmark fork

8f2448e

emilk approved these changes Apr 30, 2025

View reviewed changes

This was referenced Apr 30, 2025

Update egui to 0.32 lampsitter/egui_commonmark#76

Merged

Links are broken if they aren't the last thing in a line emilk/egui#6904

Closed

lucasmerlin added 2 commits April 30, 2025 15:57

Update threshold

543b065

Add snapshot_with_broken_pixels

42c3a09

Merge branch 'main' into lucas/egui-popup-modal-update

f6bdc43

# Conflicts: # crates/viewer/re_view_dataframe/src/view_query/ui.rs

emilk reviewed May 6, 2025

View reviewed changes

crates/viewer/re_viewer_context/src/test_context.rs Show resolved Hide resolved

lucasmerlin added 10 commits May 6, 2025 17:40

Update egui

5ab0e49

Fix trait fn

0681edd

Fixes

cf499f8

Update snapshots

f9b711c

Improve time panel strength

f1bd2b3

Make them even stronger

0840fae

Fix annotations test

bf922e6

Egui update & fixes

94a3fbd

Update snapshot (looks wrong)

dc683f6

lucasmerlin commented May 7, 2025

View reviewed changes

crates/viewer/re_time_panel/tests/snapshots/focused_item_is_focused.png Show resolved Hide resolved

lucasmerlin added 3 commits May 7, 2025 08:31

It fixed itself

555f195

Merge branch 'main' into lucas/egui-popup-modal-update

b42f09b

# Conflicts: # crates/viewer/re_selection_panel/src/defaults_ui.rs # crates/viewer/re_selection_panel/src/visualizer_ui.rs # crates/viewer/re_view/src/view_property_ui.rs

Fix after update

c0e5a14

lucasmerlin merged commit 3644768 into main May 8, 2025
37 checks passed

lucasmerlin deleted the lucas/egui-popup-modal-update branch May 8, 2025 08:17

lucasmerlin mentioned this pull request May 8, 2025

Fix notification popup instantly closing #9923

Merged

lucasmerlin added a commit that referenced this pull request May 8, 2025

Fix notification popup instantly closing (#9923)

40c1c72

### What #9103 broke the notification popup, this is the fix. Seems like `view_space_origin_widget_editing_ui` was also broken, but I'm not sure where that ui is.

Conversation

lucasmerlin commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related

What

Findings so far

Uh oh!

github-actions bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucasmerlin commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucasmerlin commented Mar 13, 2025

Uh oh!

lucasmerlin commented Apr 24, 2025

Uh oh!

lucasmerlin commented Apr 24, 2025

Uh oh!

emilk commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emilk commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emilk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

emilk Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

lucasmerlin Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

lucasmerlin commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucasmerlin commented Apr 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lucasmerlin commented Feb 21, 2025 •

edited

Loading

github-actions bot commented Feb 21, 2025 •

edited

Loading

lucasmerlin commented Feb 28, 2025 •

edited

Loading

emilk commented Apr 24, 2025 •

edited

Loading

emilk commented Apr 24, 2025 •

edited

Loading

lucasmerlin commented Apr 30, 2025 •

edited

Loading