Mark all keys as up if the app loses focus#5743
Merged
Conversation
emilk
added
bug
emilk
changed the title
|
Preview available at https://egui-pr-preview.github.io/pr/5743-emilkfix-sticky-keys |
darkwater
pushed a commit
to darkwater/egui
that referenced
this pull request
Aug 24, 2025
In Rerun, pressing `Cmd+S` brings up a save dialog using `rfd`, but we get not key-up event for the `S` key (in winit). This leads to `S` being mistakenly marked as down when we switch back to the app. This PR takes the safe route and marks all keys as up when an egui app loses focus. * Tested with rerun-io/rerun#9103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Rerun, pressing
Cmd+Sbrings up a save dialog usingrfd, but we get not key-up event for theSkey (in winit).This leads to
Sbeing mistakenly marked as down when we switch back to the app.This PR takes the safe route and marks all keys as up when an egui app loses focus.