Fix links and text selection in horizontal_wrapped layout#6905
Merged
lucasmerlin merged 4 commits intomasterfrom May 6, 2025
Merged
Fix links and text selection in horizontal_wrapped layout#6905lucasmerlin merged 4 commits intomasterfrom
lucasmerlin merged 4 commits intomasterfrom
Conversation
This was referenced Apr 30, 2025
|
Preview available at https://egui-pr-preview.github.io/pr/6905-lucasfix-links-in-horizontal-wrapping |
emilk
reviewed
May 2, 2025
emilk
approved these changes
May 6, 2025
darkwater
pushed a commit
to darkwater/egui
that referenced
this pull request
Aug 24, 2025
* Closes <emilk#6904> * [x] I have followed the instructions in the PR template This was broken in emilk#5411. Not sure if this is the best fix or if `PlacedRow::rect` should be updated, but I think it makes sense that PlacedRow::rect ignores leading space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken in #5411. Not sure if this is the best fix or if
PlacedRow::rectshould be updated, but I think it makes sense that PlacedRow::rect ignores leading space.