Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HEVC/H.265 video with hev1 flavor (in addition to hvc1) #7569

Merged
merged 6 commits into from
Oct 3, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 2, 2024

What

In short: we supported some kinds of hevc and not others.

image image

Test videos:
https://rerun.io/viewer/pr/7569?url=https://static.rerun.io/rrd/0.19.0/hvc1_5b55f7b0f38dc9ce3fca58b8e0ec9f1e084aa8a9.rrd
https://rerun.io/viewer/pr/7569?url=https://static.rerun.io/rrd/0.19.0/hev1_1132ff3c2853de110ae7f323af10bbc1a556ac17.rrd

TODO gather testing data from...

  • Windows Chrome
  • Windows Firefox
  • Linux Chrome
  • Linux Firefox
  • More linux Chrome samples - the note there is tentative so far.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Deployed docs

Commit Link
be14b66 https://landing-lqylv3j34-rerun.vercel.app/docs

@Wumpf Wumpf added the do-not-merge Do not merge this PR label Oct 2, 2024
@Wumpf Wumpf marked this pull request as ready for review October 2, 2024 16:12
@Wumpf Wumpf changed the title Support HEVC/H.264 video with hev1 flavor (in addition to hvc1) Support HEVC/H.265 video with hev1 flavor (in addition to hvc1) Oct 2, 2024
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Oct 2, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Oct 2, 2024

image

@Wumpf Wumpf merged commit 4be6c3c into main Oct 3, 2024
32 of 34 checks passed
@Wumpf Wumpf deleted the andreas/fix-hev1-parsing branch October 3, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants