Support parsing hev1 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Wumpf
added
exclude from changelog
Wumpf
force-pushed
the
andreas/hev1-support
branch
from
2ea1296
to
7a106fb
Compare
|
(drive-by: Do you mean |
|
oops. Also copy & paste error on the quoted doc there |
Wumpf
force-pushed
the
andreas/hev1-support
branch
from
7a106fb
to
6604a68
Compare
Wumpf
added a commit
to rerun-io/rerun
that referenced
this pull request
Oct 3, 2024
### What * Details over on rerun-io/re_mp4#9 In short: we supported some kinds of hevc and not others. <img width="295" alt="image" src="https://github.com/user-attachments/assets/570115c5-bbd0-4624-bf55-eaf9a9679e52"> <img width="295" alt="image" src="https://github.com/user-attachments/assets/a85bc5d7-7b4d-43e6-a1d3-972c6bbed3b0"> Test videos: https://rerun.io/viewer/pr/7569?url=https://static.rerun.io/rrd/0.19.0/hvc1_5b55f7b0f38dc9ce3fca58b8e0ec9f1e084aa8a9.rrd https://rerun.io/viewer/pr/7569?url=https://static.rerun.io/rrd/0.19.0/hev1_1132ff3c2853de110ae7f323af10bbc1a556ac17.rrd TODO gather testing data from... * [x] Windows Chrome * [x] Windows Firefox * [x] Linux Chrome * [x] Linux Firefox * [x] More linux Chrome samples - the note there is tentative so far. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7569?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7569?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7569) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEVC (H.265) comes in two flavors:
hvc1andhev1. To quote from the newly added docs:So far, we failed to load hev1, not detecting it as a video at all!
This PR..
stsdbox implementation more rusty/less insaneConfirmed before/after in Rerun: Before we'd fail to load hev1.mp4 in Chrome (but succeed with hvc1.mp4), after we succeed!
See
Commit by commit!