Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rerun-py use an embedded rerun-cli executable #5996

Merged
merged 42 commits into from
Apr 18, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Apr 16, 2024

What

  • Resolves: Split viewer binary out from python_bridge.so #5196

  • Move rerun_py over to a dependency on re_sdk instead of rerun

  • Modify the pyproject / build script to look for a bin/rerun in the python project.

  • Update the launch/spawn scripts to use the embedded copy of the rerun executable.

  • Spawn now dispatches through the SDK the same way as cpp / rust.

  • When executed inside the editable dev environment, use the copy of rerun from target/debug

  • Build and upload a copy of rerun-cli to embed into the wheel during PR builds.

  • Verify wheels build correctly on nightly

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

Copy link

github-actions bot commented Apr 16, 2024

Deployed docs

Commit Link
4a95061 https://landing-qavaj5zv2-rerun.vercel.app/docs

@jleibs jleibs force-pushed the jleibs/rerun_viewer_py_split branch from 540b804 to 2bdb6fd Compare April 17, 2024 00:38
@jleibs jleibs marked this pull request as ready for review April 17, 2024 15:20
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

.github/workflows/nightly.yml Outdated Show resolved Hide resolved
rerun_py/src/python_bridge.rs Show resolved Hide resolved
rerun_py/rerun_sdk/rerun/_spawn.py Outdated Show resolved Hide resolved
rerun_py/rerun_sdk/rerun/_spawn.py Outdated Show resolved Hide resolved
rerun_py/rerun_sdk/rerun/_spawn.py Outdated Show resolved Hide resolved
rerun_py/build.rs Outdated Show resolved Hide resolved
rerun_py/build.rs Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
pixi.toml Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
@jleibs jleibs merged commit cbe281b into main Apr 18, 2024
39 checks passed
@jleibs jleibs deleted the jleibs/rerun_viewer_py_split branch April 18, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split viewer binary out from python_bridge.so
3 participants