-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rerun-py use an embedded rerun-cli executable #5996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the target rerun-cli anyways
Deployed docs
|
jleibs
force-pushed
the
jleibs/rerun_viewer_py_split
branch
from
April 17, 2024 00:38
540b804
to
2bdb6fd
Compare
emilk
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves: Split viewer binary out from python_bridge.so #5196
Move
rerun_py
over to a dependency onre_sdk
instead ofrerun
Modify the pyproject / build script to look for a bin/rerun in the python project.
Update the launch/spawn scripts to use the embedded copy of the
rerun
executable.Spawn now dispatches through the SDK the same way as cpp / rust.
When executed inside the editable dev environment, use the copy of
rerun
fromtarget/debug
Build and upload a copy of rerun-cli to embed into the wheel during PR builds.
Verify wheels build correctly on nightly
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.