Skip to content

Commit

Permalink
Build rerun-cli before building the wheel
Browse files Browse the repository at this point in the history
  • Loading branch information
jleibs committed Apr 17, 2024
1 parent c0d09c3 commit 2bdb6fd
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 2 deletions.
12 changes: 10 additions & 2 deletions .github/workflows/on_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,14 @@ jobs:
FULL: "true"
secrets: inherit

# Build and test a single wheel to limit CI cost. We use linux-x64 because it's fast. linux-arm64 would also be a good
# choice, but reusable_test_wheels.yml is broken for that target (https://github.com/rerun-io/rerun/issues/5525)
min-cli-build:
name: "Minimum CLI Build"
uses: ./.github/workflows/reusable_build_and_upload_rerun_cli.yml
with:
CONCURRENCY: pr-${{ github.event.pull_request.number }}
PLATFORM: linux-x64
secrets: inherit

min-wheel-build:
name: "Minimum Wheel Build"
needs: [python-paths-filter, rust-paths-filter]
Expand All @@ -175,6 +181,8 @@ jobs:
WHEEL_ARTIFACT_NAME: "linux-x64-wheel-fast"
secrets: inherit

# Build and test a single wheel to limit CI cost. We use linux-x64 because it's fast. linux-arm64 would also be a good
# choice, but reusable_test_wheels.yml is broken for that target (https://github.com/rerun-io/rerun/issues/5525)
min-wheel-test:
name: "Minimum Wheel Test"
needs: [min-wheel-build, python-paths-filter, rust-paths-filter]
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/reusable_build_and_upload_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,13 @@ jobs:
full_commit="${{ inputs.RELEASE_COMMIT || ((github.event_name == 'pull_request' && github.event.pull_request.head.ref) || github.sha) }}"
echo "sha=$(echo $full_commit | cut -c1-7)" >> "$GITHUB_OUTPUT"
- name: "Download rerun-cli"
run: pixi run fetch-artifact \
--commit-sha ${{ steps.get-sha.outputs.sha }} \
--artifact-name rerun-cli \
--platform-name ${{ inputs.PLATFORM }} \
--dest rerun_py/rerun_sdk/bin

- name: Build
shell: bash
run: |
Expand Down
2 changes: 2 additions & 0 deletions pixi.toml
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ upload-image = "python scripts/upload_image.py"
# Check whether there's too large files in the repository.
check-large-files = "python scripts/ci/check_large_files.py"

fetch-artifact = "python scripts/fetch_artifact.py"

[feature.py-docs.tasks]
# Serve python docs locally
py-docs-serve = "mkdocs serve -f rerun_py/mkdocs.yml -w rerun_py"
Expand Down

0 comments on commit 2bdb6fd

Please sign in to comment.