Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl-c kills Rerun view in addition to python application #6186

Closed
jleibs opened this issue May 1, 2024 · 2 comments · Fixed by #6260
Closed

Ctrl-c kills Rerun view in addition to python application #6186

jleibs opened this issue May 1, 2024 · 2 comments · Fixed by #6260
Assignees
@jleibs
Labels
🐍 Python API Python logging API 🦟 regression A thing that used to work in an earlier release
Milestone
0.16

Comments

@jleibs
Copy link
Member

jleibs commented May 1, 2024

This seems to be a regression related to #5996

Previously ctrl-c would always go to the script and leave the rerun process running.
@jleibs jleibs added 🐍 Python API Python logging API 🦟 regression A thing that used to work in an earlier release labels May 1, 2024
@jleibs jleibs added this to the 0.16 milestone May 1, 2024
@jleibs
Copy link
Member Author

jleibs commented May 1, 2024

Note, this now matches the behavior of spawning from a rust application. We probably want to address this directly in spawn.rs

@emilk
Copy link
Member

emilk commented May 7, 2024

Let's fix it for all languages and all OSes. I want to be able to kill my app without killing the viewer.

@jleibs jleibs mentioned this issue May 7, 2024
Merged
8 tasks
@jleibs jleibs self-assigned this May 7, 2024
jleibs added a commit that referenced this issue May 8, 2024
@jleibs
Keep rerun viewer from dying on ctrl-c by setting sid on unix systems (…
1942b43 
…#6260)

### What
- Resolves: #6186

Testing:
 - [x] Works on linux
 - [x] Works on Mac
 - [x] Works on Windows

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6260?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6260?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6260)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleibs jleibs

Labels
🐍 Python API Python logging API 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
0.16
Development

Successfully merging a pull request may close this issue.

Keep rerun viewer from dying on ctrl-c by setting sid on unix systems rerun-io/rerun
2 participants
@emilk @jleibs