Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Welcome Screen and use card-based layout for examples #5699

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Simplify Welcome Screen and use card-based layout for examples #5699

merged 5 commits into from
Mar 27, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Mar 27, 2024 •
edited by github-actions bot
Loading

What

Note: the "Source code" links are functional but disabled, as the example manifest must be updated to include the corresponding URL, see follow-up issues.

Follow-up:

Before/After:

image image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Mar 27, 2024
This was referenced Mar 27, 2024
Closed
Closed
Merged
Merged
@emilk
Copy link
Member

emilk commented Mar 27, 2024 •
edited
Loading

The hover effect is way too subtle imho (at least in a bright room). It would be good if the full rectangle got highlighted somehow e.g. by:

  • Making it bigger (e.g. overlay an additive white rect)
  • Making it brighter
  • Adding an outline

subtle-hover

emilk
emilk approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think we need a better hover-effect. Adding an Color32::from_additive_luminance(32) or so rect fill on it should do the trick

crates/re_ui/data/icons/github.png Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/welcome_screen/example_section.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/welcome_screen/example_section.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/welcome_screen/example_section.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/welcome_screen/example_section.rs Outdated Show resolved Hide resolved
crates/re_ui/src/design_tokens.rs Outdated Show resolved Hide resolved
@abey79
Copy link
Member Author

abey79 commented Mar 27, 2024

Looks great, but I think we need a better hover-effect. Adding an Color32::from_additive_luminance(32) or so rect fill on it should do the trick

I did that, albeit with a value of 25, it's pretty nice 👍🏻

@emilk
Copy link
Member

emilk commented Mar 27, 2024

Nice, the new hover effect works great!

@abey79 abey79 merged commit 8cf3f92 into main Mar 27, 2024
34 checks passed
@abey79 abey79 deleted the antoine/updated-welcome-screen branch March 27, 2024 19:05
abey79 added a commit that referenced this pull request Mar 27, 2024
@abey79
Add source URL to example manifest (#5703)
88f2156 
### What

- Fixes #5701 
- Follow-up to #5699 

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5703/index.html) - **LINKS SHOULD
WORK _ONLY_ HERE**
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5703/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5703/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5703)
- [Docs
preview](https://rerun.io/preview/0530608694da108802e9898c85ea22905aadb3c5/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/0530608694da108802e9898c85ea22905aadb3c5/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
abey79 added a commit that referenced this pull request Mar 27, 2024
@abey79
Update thumbnails for some in-app examples (#5707)
2ebe679 
### What

- Closes #5700 
- Follow-up to #5699 

These were missing an up-to-date thumbnail.

<img width="319" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/ef5bccf5-cb8b-4e62-b28b-5aa812c5bec1">

<img width="277" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/632f759f-cb3b-4a2a-88e6-bb587adc7cf0">



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5707/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5707/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5707/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5707)
- [Docs
preview](https://rerun.io/preview/28c1ce40fe0ac71a99c40ec2a0525e3a14405478/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/28c1ce40fe0ac71a99c40ec2a0525e3a14405478/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@jprochazk jprochazk mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Card based example gallery in the application welcome screen
2 participants
@abey79 @emilk