Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example thumbnails #5700

Closed
abey79 opened this issue Mar 27, 2024 · 0 comments · Fixed by #5707
Closed

Update example thumbnails #5700

abey79 opened this issue Mar 27, 2024 · 0 comments · Fixed by #5707
Assignees
@abey79
Labels
examples Issues relating to the Rerun examples
Milestone
0.15

Comments

@abey79
Copy link
Member

abey79 commented Mar 27, 2024

Some of the example thumbnails do not look good after #5699. They must be recreated as zoomed-in, 480x480 thumbnail.

Good/not good:

image
@abey79 abey79 added the examples Issues relating to the Rerun examples label Mar 27, 2024
@abey79 abey79 added this to the 0.15 milestone Mar 27, 2024
@abey79 abey79 changed the title Add source URL to example manifest Update example thumbnails Mar 27, 2024
@abey79 abey79 self-assigned this Mar 27, 2024
This was referenced Mar 27, 2024
Merged
Merged
abey79 added a commit that referenced this issue Mar 27, 2024
@abey79
Simplify Welcome Screen and use card-based layout for examples (#5699)
8cf3f92 
### What

* Closes #5452 

Note: the "Source code" links are functional but disabled, as the
example manifest must be updated to include the corresponding URL, see
follow-up issues.

Follow-up:
- #5700 
- #5701 

Before/After:

<img width="844" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/ded75ce3-600d-4c0c-bfa0-7742e9fad503">

<img width="1043" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/87f33dc9-154f-42b0-bdda-3647c71a6c90">



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5699/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5699/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5699/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5699)
- [Docs
preview](https://rerun.io/preview/6766af1787603295c4d4970a1c98849677409942/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/6766af1787603295c4d4970a1c98849677409942/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
abey79 added a commit that referenced this issue Mar 27, 2024
@abey79
Update thumbnails for some in-app examples (#5707)
2ebe679 
### What

- Closes #5700 
- Follow-up to #5699 

These were missing an up-to-date thumbnail.

<img width="319" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/ef5bccf5-cb8b-4e62-b28b-5aa812c5bec1">

<img width="277" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/632f759f-cb3b-4a2a-88e6-bb587adc7cf0">



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5707/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5707/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5707/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5707)
- [Docs
preview](https://rerun.io/preview/28c1ce40fe0ac71a99c40ec2a0525e3a14405478/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/28c1ce40fe0ac71a99c40ec2a0525e3a14405478/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
examples Issues relating to the Rerun examples
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Update thumbnails for some in-app examples rerun-io/rerun
1 participant
@abey79