New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source URL to example manifest #5701

Closed

abey79 opened this issue Mar 27, 2024 · 0 comments · Fixed by #5703

Assignees

Labels

examples

Milestone

Member

abey79 commented Mar 27, 2024

#5699 introduces links to example source. We must add the corresponding URL to the example manifest.

abey79 added the examples label

abey79 added this to the 0.15 milestone

abey79 self-assigned this

abey79 mentioned this issue

Simplify Welcome Screen and use card-based layout for examples #5699

Merged

5 tasks

teh-cmc changed the title ~~Add source ULR to example manifest~~ Add source URL to example manifest

abey79 mentioned this issue

Add source URL to example manifest #5703

Merged

5 tasks

abey79 added a commit that referenced this issue


          Simplify Welcome Screen and use card-based layout for examples (#5699)

8cf3f92

### What

* Closes #5452 

Note: the "Source code" links are functional but disabled, as the
example manifest must be updated to include the corresponding URL, see
follow-up issues.

Follow-up:
- #5700 
- #5701 

Before/After:

<img width="844" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/ded75ce3-600d-4c0c-bfa0-7742e9fad503">

<img width="1043" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/87f33dc9-154f-42b0-bdda-3647c71a6c90">



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5699/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5699/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5699/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5699)
- [Docs
preview](https://rerun.io/preview/6766af1787603295c4d4970a1c98849677409942/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/6766af1787603295c4d4970a1c98849677409942/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

abey79 closed this as completed in #5703

abey79 added a commit that referenced this issue


          Add source URL to example manifest (#5703)

88f2156

### What

- Fixes #5701 
- Follow-up to #5699 

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5703/index.html) - **LINKS SHOULD
WORK _ONLY_ HERE**
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5703/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5703/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5703)
- [Docs
preview](https://rerun.io/preview/0530608694da108802e9898c85ea22905aadb3c5/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/0530608694da108802e9898c85ea22905aadb3c5/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment