Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated TimeSeriesScalar #5604

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Remove deprecated TimeSeriesScalar #5604

merged 2 commits into from
Mar 21, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Mar 20, 2024 •
edited by github-actions bot
Loading

It's now officially getting in my way. 🔪

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@teh-cmc teh-cmc added 🐍 Python API Python logging API 🦀 Rust API Rust logging API 🌊 C++ API C/C++ API specific include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Mar 20, 2024
@Wumpf Wumpf self-requested a review March 20, 2024 17:55
@github-actions GitHub Actions
Copy link

Size changes

Name main 5604/merge Change
re_sdk --no-default-features 117 crates 111 crates -6 crates

Wumpf
Wumpf approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good riddance! :)

@teh-cmc teh-cmc merged commit cc0e895 into main Mar 21, 2024
39 checks passed
@teh-cmc teh-cmc deleted the cmc/rm_old_scalar branch March 21, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @Wumpf