Remove deprecated TimeSeriesScalar (#5604)

It's now officially getting in my way. 🔪
rerun-io · Mar 21, 2024 · cc0e895 · cc0e895
1 parent 69f5aac
commit cc0e895
Show file tree

Hide file tree

Showing 37 changed files with 25 additions and 1,283 deletions.
diff --git a/crates/re_query_cache/src/flat_vec_deque.rs b/crates/re_query_cache/src/flat_vec_deque.rs
@@ -111,8 +111,7 @@ impl<T: SizeBytes + 'static> ErasedFlatVecDeque for FlatVecDeque<T> {
 /// optimizes for writes.
 ///
 /// You can think of this as the native/deserialized version of an Arrow `ListArray`.
-/// This is particularly useful when working with many small arrays of data (e.g. Rerun's
-/// `TimeSeriesScalar`s).
+/// This is particularly useful when working with many small arrays of data (e.g. Rerun's `Scalar`s).
 //
 // TODO(cmc): We could even use a bitmap for T=Option<Something>, which would bring this that much
 // closer to a deserialized version of an Arrow array.

diff --git a/crates/re_space_view_time_series/src/legacy_visualizer_system.rs b/crates/re_space_view_time_series/src/legacy_visualizer_system.rs
diff --git a/crates/re_space_view_time_series/src/lib.rs b/crates/re_space_view_time_series/src/lib.rs
@@ -3,7 +3,6 @@
 //! A Space View that shows plots over Rerun timelines.
 
 mod aggregation;
-mod legacy_visualizer_system;
 mod line_visualizer_system;
 mod overrides;
 mod point_visualizer_system;

diff --git a/crates/re_space_view_time_series/src/space_view_class.rs b/crates/re_space_view_time_series/src/space_view_class.rs
@@ -19,7 +19,6 @@ use re_viewer_context::{
     ViewerContext, VisualizableEntities,
 };
 
-use crate::legacy_visualizer_system::LegacyTimeSeriesSystem;
 use crate::line_visualizer_system::SeriesLineSystem;
 use crate::point_visualizer_system::SeriesPointSystem;
 use crate::PlotSeriesKind;
@@ -121,7 +120,6 @@ impl SpaceViewClass for TimeSeriesSpaceView {
         &self,
         system_registry: &mut re_viewer_context::SpaceViewSystemRegistrator<'_>,
     ) -> Result<(), SpaceViewClassRegistryError> {
-        system_registry.register_visualizer::<LegacyTimeSeriesSystem>()?;
         system_registry.register_visualizer::<SeriesLineSystem>()?;
         system_registry.register_visualizer::<SeriesPointSystem>()?;
         Ok(())
@@ -190,7 +188,6 @@ It can greatly improve performance (and readability) in such situations as it pr
         let mut indicated_entities = IndicatedEntities::default();
 
         for indicated in [
-            LegacyTimeSeriesSystem::identifier(),
             SeriesLineSystem::identifier(),
             SeriesPointSystem::identifier(),
         ]
@@ -341,13 +338,10 @@ It can greatly improve performance (and readability) in such situations as it pr
 
         let timeline_name = timeline.name().to_string();
 
-        let legacy_time_series = system_output.view_systems.get::<LegacyTimeSeriesSystem>()?;
         let line_series = system_output.view_systems.get::<SeriesLineSystem>()?;
         let point_series = system_output.view_systems.get::<SeriesPointSystem>()?;
 
-        let all_plot_series: Vec<_> = legacy_time_series
-            .all_series
-            .iter()
+        let all_plot_series: Vec<_> = std::iter::empty()
             .chain(line_series.all_series.iter())
             .chain(point_series.all_series.iter())
             .collect();

diff --git a/crates/re_types/definitions/rerun/archetypes.fbs b/crates/re_types/definitions/rerun/archetypes.fbs
@@ -22,7 +22,6 @@ include "./archetypes/series_point.fbs";
 include "./archetypes/tensor.fbs";
 include "./archetypes/text_document.fbs";
 include "./archetypes/text_log.fbs";
-include "./archetypes/time_series_scalar.fbs";
 include "./archetypes/transform3d.fbs";
 include "./archetypes/view_coordinates.fbs";