Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated TimeSeriesScalar #5604

Merged
merged 2 commits into from
Mar 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/re_query_cache/src/flat_vec_deque.rs
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ impl<T: SizeBytes + 'static> ErasedFlatVecDeque for FlatVecDeque<T> {
/// optimizes for writes.
///
/// You can think of this as the native/deserialized version of an Arrow `ListArray`.
/// This is particularly useful when working with many small arrays of data (e.g. Rerun's
/// `TimeSeriesScalar`s).
/// This is particularly useful when working with many small arrays of data (e.g. Rerun's `Scalar`s).
//
// TODO(cmc): We could even use a bitmap for T=Option<Something>, which would bring this that much
// closer to a deserialized version of an Arrow array.
Expand Down
276 changes: 0 additions & 276 deletions crates/re_space_view_time_series/src/legacy_visualizer_system.rs

This file was deleted.

1 change: 0 additions & 1 deletion crates/re_space_view_time_series/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
//! A Space View that shows plots over Rerun timelines.
mod aggregation;
mod legacy_visualizer_system;
mod line_visualizer_system;
mod overrides;
mod point_visualizer_system;
Expand Down
8 changes: 1 addition & 7 deletions crates/re_space_view_time_series/src/space_view_class.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ use re_viewer_context::{
ViewerContext, VisualizableEntities,
};

use crate::legacy_visualizer_system::LegacyTimeSeriesSystem;
use crate::line_visualizer_system::SeriesLineSystem;
use crate::point_visualizer_system::SeriesPointSystem;
use crate::PlotSeriesKind;
Expand Down Expand Up @@ -121,7 +120,6 @@ impl SpaceViewClass for TimeSeriesSpaceView {
&self,
system_registry: &mut re_viewer_context::SpaceViewSystemRegistrator<'_>,
) -> Result<(), SpaceViewClassRegistryError> {
system_registry.register_visualizer::<LegacyTimeSeriesSystem>()?;
system_registry.register_visualizer::<SeriesLineSystem>()?;
system_registry.register_visualizer::<SeriesPointSystem>()?;
Ok(())
Expand Down Expand Up @@ -190,7 +188,6 @@ It can greatly improve performance (and readability) in such situations as it pr
let mut indicated_entities = IndicatedEntities::default();

for indicated in [
LegacyTimeSeriesSystem::identifier(),
SeriesLineSystem::identifier(),
SeriesPointSystem::identifier(),
]
Expand Down Expand Up @@ -341,13 +338,10 @@ It can greatly improve performance (and readability) in such situations as it pr

let timeline_name = timeline.name().to_string();

let legacy_time_series = system_output.view_systems.get::<LegacyTimeSeriesSystem>()?;
let line_series = system_output.view_systems.get::<SeriesLineSystem>()?;
let point_series = system_output.view_systems.get::<SeriesPointSystem>()?;

let all_plot_series: Vec<_> = legacy_time_series
.all_series
.iter()
let all_plot_series: Vec<_> = std::iter::empty()
.chain(line_series.all_series.iter())
.chain(point_series.all_series.iter())
.collect();
Expand Down
1 change: 0 additions & 1 deletion crates/re_types/definitions/rerun/archetypes.fbs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ include "./archetypes/series_point.fbs";
include "./archetypes/tensor.fbs";
include "./archetypes/text_document.fbs";
include "./archetypes/text_log.fbs";
include "./archetypes/time_series_scalar.fbs";
include "./archetypes/transform3d.fbs";
include "./archetypes/view_coordinates.fbs";

Expand Down
Loading
Loading