Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove car example #5576

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Remove car example #5576

merged 1 commit into from
Mar 20, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 19, 2024

What

RGBD example is almost as good. Car was useful when we didn't have much else, but now it's mostly just ugly ;)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added examples Issues relating to the Rerun examples include in changelog labels Mar 19, 2024
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've bounced between minimal and plots because minimal lacks CLI flags.
You could also use minimal_options everywhere. I don't mind either way 🤷

@emilk
Copy link
Member

emilk commented Mar 20, 2024

Goodbye first ever example 👋

@Wumpf Wumpf merged commit ea576b7 into main Mar 20, 2024
36 checks passed
@Wumpf Wumpf deleted the andreas/remove-car-example branch March 20, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants