Skip to content

Commit

Permalink
Remove car example (#5576)
Browse files Browse the repository at this point in the history
### What

RGBD example is almost as good. Car was useful when we didn't have much
else, but now it's mostly just ugly ;)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5576/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5576/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5576/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5576)
- [Docs
preview](https://rerun.io/preview/174aaf57d6120d1d087f346503dcf1bd34ad4282/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/174aaf57d6120d1d087f346503dcf1bd34ad4282/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
  • Loading branch information
Wumpf authored Mar 20, 2024
1 parent dd84dd4 commit ea576b7
Show file tree
Hide file tree
Showing 9 changed files with 7 additions and 306 deletions.
2 changes: 1 addition & 1 deletion BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ This needs to be repeated each time the Rust source code is updated, for example

Now you can run the python examples from the repository, given that you're still in the virtual environment.
```sh
python examples/python/car/main.py
python examples/python/minimal/main.py
```

## Building and installing the Rerun C++ SDK
Expand Down
1 change: 0 additions & 1 deletion examples/manifest.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ check out [Types](/docs/reference/types).
"""
examples = [
"minimal",
"car",
"clock",
"eigen_opencv",
"multithreading",
Expand Down
8 changes: 4 additions & 4 deletions examples/python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ For example, if your SDK version is `0.4.0`, check out the matching tag
for this repository by running `git checkout v0.4.0`.

## Dependencies
Each example comes with its own set of dependencies listed in a `requirements.txt` file. For example, to install dependencies and run the toy `car` example (which doesn't need to download any data) run:
Each example comes with its own set of dependencies listed in a `requirements.txt` file. For example, to install dependencies and run the toy `minimal` example (which doesn't need to download any data) run:

```sh
pip install -r examples/python/car/requirements.txt
examples/python/car/main.py
pip install -r examples/python/minimal/requirements.txt
python examples/python/minimal/main.py
```

You can also install all dependencies needed to run all examples with:
Expand All @@ -27,7 +27,7 @@ pip install -r examples/python/requirements.txt
## Running the examples
By default, the examples spawn a Rerun Viewer and stream log data to it.

You can instead save the log data to an `.rrd` file using `examples/python/car/main.py --save data.rrd`. You can then view that `.rrd` file with `rerun data.rrd`.
For most examples you can instead save the log data to an `.rrd` file using `examples/python/plots/main.py --save data.rrd`. You can then view that `.rrd` file with `rerun data.rrd`.

(`rerun` is an alias for `python -m rerun`).

Expand Down
22 changes: 0 additions & 22 deletions examples/python/car/README.md

This file was deleted.

270 changes: 0 additions & 270 deletions examples/python/car/main.py

This file was deleted.

3 changes: 0 additions & 3 deletions examples/python/car/requirements.txt

This file was deleted.

1 change: 0 additions & 1 deletion examples/python/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
-r arkit_scenes/requirements.txt
-r blueprint/requirements.txt
-r car/requirements.txt
-r clock/requirements.txt
-r controlnet/requirements.txt
-r depth_guided_stable_diffusion/requirements.txt
Expand Down
4 changes: 2 additions & 2 deletions rerun_py/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ python3 -m rerun

In a second terminal, run the example with the `--connect` option:
```sh
python3 examples/python/car/main.py --connect
python3 python examples/python/plots/main.py --connect
```

-------------------------
Expand Down Expand Up @@ -105,7 +105,7 @@ just py-test
just py-lint

# Run an example
python examples/python/car/main.py
python examples/python/minimal/main.py
```

## Building an installable Python Wheel
Expand Down
2 changes: 0 additions & 2 deletions scripts/run_python_e2e_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def main() -> None:
if not parser.parse_args().no_pip_reqs:
requirements = [
"tests/python/test_api/requirements.txt",
"examples/python/car/requirements.txt",
"examples/python/minimal_options/requirements.txt",
"examples/python/multithreading/requirements.txt",
"examples/python/plots/requirements.txt",
Expand All @@ -62,7 +61,6 @@ def main() -> None:
examples = [
# Trivial examples that don't require weird dependencies, or downloading data
("tests/python/test_api/main.py", ["--test", "all"]),
("examples/python/car/main.py", []),
("examples/python/minimal_options/main.py", []),
("examples/python/multithreading/main.py", []),
("examples/python/plots/main.py", []),
Expand Down

0 comments on commit ea576b7

Please sign in to comment.