Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove car example #5576

Merged
merged 1 commit into from
Mar 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ This needs to be repeated each time the Rust source code is updated, for example

Now you can run the python examples from the repository, given that you're still in the virtual environment.
```sh
python examples/python/car/main.py
python examples/python/minimal/main.py
```

## Building and installing the Rerun C++ SDK
Expand Down
1 change: 0 additions & 1 deletion examples/manifest.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ check out [Types](/docs/reference/types).
"""
examples = [
"minimal",
"car",
"clock",
"eigen_opencv",
"multithreading",
Expand Down
8 changes: 4 additions & 4 deletions examples/python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ For example, if your SDK version is `0.4.0`, check out the matching tag
for this repository by running `git checkout v0.4.0`.

## Dependencies
Each example comes with its own set of dependencies listed in a `requirements.txt` file. For example, to install dependencies and run the toy `car` example (which doesn't need to download any data) run:
Each example comes with its own set of dependencies listed in a `requirements.txt` file. For example, to install dependencies and run the toy `minimal` example (which doesn't need to download any data) run:

```sh
pip install -r examples/python/car/requirements.txt
examples/python/car/main.py
pip install -r examples/python/minimal/requirements.txt
python examples/python/minimal/main.py
```

You can also install all dependencies needed to run all examples with:
Expand All @@ -27,7 +27,7 @@ pip install -r examples/python/requirements.txt
## Running the examples
By default, the examples spawn a Rerun Viewer and stream log data to it.

You can instead save the log data to an `.rrd` file using `examples/python/car/main.py --save data.rrd`. You can then view that `.rrd` file with `rerun data.rrd`.
For most examples you can instead save the log data to an `.rrd` file using `examples/python/plots/main.py --save data.rrd`. You can then view that `.rrd` file with `rerun data.rrd`.

(`rerun` is an alias for `python -m rerun`).

Expand Down
22 changes: 0 additions & 22 deletions examples/python/car/README.md

This file was deleted.

270 changes: 0 additions & 270 deletions examples/python/car/main.py

This file was deleted.

3 changes: 0 additions & 3 deletions examples/python/car/requirements.txt

This file was deleted.

1 change: 0 additions & 1 deletion examples/python/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
-r arkit_scenes/requirements.txt
-r blueprint/requirements.txt
-r car/requirements.txt
-r clock/requirements.txt
-r controlnet/requirements.txt
-r depth_guided_stable_diffusion/requirements.txt
Expand Down
4 changes: 2 additions & 2 deletions rerun_py/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ python3 -m rerun

In a second terminal, run the example with the `--connect` option:
```sh
python3 examples/python/car/main.py --connect
python3 python examples/python/plots/main.py --connect
```

-------------------------
Expand Down Expand Up @@ -105,7 +105,7 @@ just py-test
just py-lint

# Run an example
python examples/python/car/main.py
python examples/python/minimal/main.py
```

## Building an installable Python Wheel
Expand Down
2 changes: 0 additions & 2 deletions scripts/run_python_e2e_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def main() -> None:
if not parser.parse_args().no_pip_reqs:
requirements = [
"tests/python/test_api/requirements.txt",
"examples/python/car/requirements.txt",
"examples/python/minimal_options/requirements.txt",
"examples/python/multithreading/requirements.txt",
"examples/python/plots/requirements.txt",
Expand All @@ -62,7 +61,6 @@ def main() -> None:
examples = [
# Trivial examples that don't require weird dependencies, or downloading data
("tests/python/test_api/main.py", ["--test", "all"]),
("examples/python/car/main.py", []),
("examples/python/minimal_options/main.py", []),
("examples/python/multithreading/main.py", []),
("examples/python/plots/main.py", []),
Expand Down
Loading