-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include multi-platform dockerbuild with arm64 support #5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
🚢 CI
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
Mar 15, 2024
jleibs
force-pushed
the
jleibs/docker_arm
branch
from
March 15, 2024 19:33
bcae3ce
to
dc2b59f
Compare
abey79
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Preemptively approving in case CI agrees :)
abey79
added a commit
that referenced
this pull request
Mar 18, 2024
### What Build linux-aarch64 wheels (with manylinux_2_31) and fixes the C and CLI builds to bring the min required glibc version to 2.31. **Note**: cursory inspection indicates that the _actual_ min glibc version 2.29. However, we don't formally test that. The only test is done by `maturin` on our wheels, against the `manylinux_2_31` standard. Amongst other things, this PR: - updates our ci docker image to be compatible with aarch64 (#5543 – thanks @jleibs) - remove all instances of double GCS authentication (our setup-rust action auth to GCS, so an explicit auth isn't necessary, _and_ would break cleanup in linux-arm/cli build workflow—why there only is unclear) - use it for all linux-aarch64 builds - fixes `pixi.toml` for linux-aarch64 compatibility - bumps pixi to 0.16.1 everywhere in the ci - adds a manual trigger for building wheels - (mostly) unifies the target naming scheme #### Related - Follow-up to: - #5489 - #5503 - Closes #4136 - Fixes #5507 #### Further work - ~~support lower glibc version: #5512 - test more wheels: #5525 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5511/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5511/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5511/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5511) - [Docs preview](https://rerun.io/preview/c029b411730d035b9babdba3f9721dbe2905196b/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/c029b411730d035b9babdba3f9721dbe2905196b/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Successful buildjet run: https://github.com/rerun-io/rerun/actions/runs/8301499563/job/22721760001
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io