Build wheels for Linux ARM64 #5511

abey79 · 2024-03-14T17:04:05Z

What

Build linux-aarch64 wheels (with manylinux_2_31) and fixes the C and CLI builds to bring the min required glibc version to 2.31.

Note: cursory inspection indicates that the actual min glibc version 2.29. However, we don't formally test that. The only test is done by maturin on our wheels, against the manylinux_2_31 standard.

Amongst other things, this PR:

updates our ci docker image to be compatible with aarch64 (Include multi-platform dockerbuild with arm64 support #5543 – thanks @jleibs)
remove all instances of double GCS authentication (our setup-rust action auth to GCS, so an explicit auth isn't necessary, and would break cleanup in linux-arm/cli build workflow—why there only is unclear)
use it for all linux-aarch64 builds
fixes pixi.toml for linux-aarch64 compatibility
bumps pixi to 0.16.1 everywhere in the ci
adds a manual trigger for building wheels
(mostly) unifies the target naming scheme

Further work

~~support lower glibc version: Improve the glibc minimum supported version #5512~~
test more wheels: Test wheels on all platforms #5525

Checklist

I have read and agree to Contributor Guide and the Code of Conduct
I've included a screenshot or gif (if applicable)
I have tested the web demo (if applicable):
- Using newly built examples: app.rerun.io
- Using examples from latest main build: app.rerun.io
- Using full set of examples from nightly build: app.rerun.io
The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
If applicable, add a new check to the release checklist!

emilk

Yup, that yaml sure looks like yaml to me!

.github/workflows/on_pull_request.yml

.github/workflows/on_push_main.yml

pixi.toml

…6.1 everywhere

# Conflicts: # pixi.toml

### What I need that to test #5511 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }}) - [Docs preview](https://rerun.io/preview/{{ pr.commit }}/docs)  - [Examples preview](https://rerun.io/preview/{{ pr.commit }}/examples)  - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

abey79 · 2024-03-15T09:56:31Z

Testing builds for all wheels with ca13fdc

https://github.com/rerun-io/rerun/actions/runs/8294337164
https://github.com/rerun-io/rerun/actions/runs/8294338708
https://github.com/rerun-io/rerun/actions/runs/8294341078
https://github.com/rerun-io/rerun/actions/runs/8294343144
https://github.com/rerun-io/rerun/actions/runs/8294345322

all ✅

❯ gcloud storage ls gs://rerun-builds/commit/ca13fdc/wheels/
gs://rerun-builds/commit/ca13fdc/wheels/rerun_sdk-0.15.0a2-cp38-abi3-macosx_10_12_x86_64.whl
gs://rerun-builds/commit/ca13fdc/wheels/rerun_sdk-0.15.0a2-cp38-abi3-macosx_11_0_arm64.whl
gs://rerun-builds/commit/ca13fdc/wheels/rerun_sdk-0.15.0a2-cp38-abi3-manylinux_2_31_x86_64.whl
gs://rerun-builds/commit/ca13fdc/wheels/rerun_sdk-0.15.0a2-cp38-abi3-manylinux_2_35_aarch64.whl
gs://rerun-builds/commit/ca13fdc/wheels/rerun_sdk-0.15.0a2-cp38-abi3-win_amd64.whl

Resulting linux-aarch64 wheel: http://build.rerun.io/commit/ca13fdc/wheels/rerun_sdk-0.15.0a2-cp38-abi3-manylinux_2_35_aarch64.whl

Works on a RPi 5 with glibc 3.36

jleibs · 2024-03-15T19:27:18Z

Ok, as of #5543 rerunio/ci_docker:0.12.0 should be able to run on arm.

### What - Switch to using docker buildx to create the docker environment - Update the platform-specific parts of the dockerfile to use the targetplatform - Bump the version to 0.12 just in case something goes wrong. - Start using the docker container on buildjet ``` $ docker buildx imagetools inspect rerunio/ci_docker:0.12.0 Name: docker.io/rerunio/ci_docker:0.12.0 MediaType: application/vnd.oci.image.index.v1+json Digest: sha256:9575a44a30152ef292c8f73e9546f1d431ea32246bc7a0043ba51f4df936c537 Manifests: Name: docker.io/rerunio/ci_docker:0.12.0@sha256:7e0e5a31234578d10c53733e9e703972d73ac7df992323d95feb60700cb94e4b MediaType: application/vnd.oci.image.manifest.v1+json Platform: linux/arm64 Name: docker.io/rerunio/ci_docker:0.12.0@sha256:e1861e823b15b3accf103c00910fa24a89aa274f02550b5458524322cc1f39ce MediaType: application/vnd.oci.image.manifest.v1+json Platform: linux/amd64 ``` Successful buildjet run: https://github.com/rerun-io/rerun/actions/runs/8301499563/job/22721760001 ![image](https://github.com/rerun-io/rerun/assets/3312232/8524e28e-8630-4c1e-a0e1-972e5a928487) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5543/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5543/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5543/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5543) - [Docs preview](https://rerun.io/preview/3eb7524e2f955e97dcb423b6a16c10f7fdb75ba9/docs)  - [Examples preview](https://rerun.io/preview/3eb7524e2f955e97dcb423b6a16c10f7fdb75ba9/examples)  - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

This reverts commit 2a4092e.

abey79 · 2024-03-16T07:16:34Z

Back to draft... Using our shiny new docker image for the c build appears to work: https://github.com/rerun-io/rerun/actions/runs/8306070007/job/22733709381

The same isn't quite true yet for the CLI: https://github.com/rerun-io/rerun/actions/runs/8306071147/job/22733711751

# Conflicts: # .github/workflows/reusable_test_wheels.yml

abey79 · 2024-03-18T09:21:46Z

Hopefully final set of test builds (on c029b41):

All are ✅ 🎉

Linux-aarch64 artefacts:
https://build.rerun.io/commit/c029b41/wheels/rerun_sdk-0.15.0a2-cp38-abi3-manylinux_2_31_aarch64.whl
https://build.rerun.io/commit/c029b41/rerun_c/linux-arm64/librerun_c.a
https://build.rerun.io/commit/c029b41/rerun-cli/linux-arm64/rerun

### What CI on main has not been running at all since #5511 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }}) - [Docs preview](https://rerun.io/preview/{{ pr.commit }}/docs)  - [Examples preview](https://rerun.io/preview/{{ pr.commit }}/examples)  - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

emilk · 2024-04-10T16:42:15Z

.github/workflows/reusable_test_wheels.yml

+        # TODO(#5525): at least this target is broken, maybe others — we currently only use linux-x64 and windows-x64
        run: |


What target is "this" referring to?

badly placed comment, it should be attached to the linux-arm64 arm. pretty sure the mac targets are broken as well, but i hadn't tested then iirc

Tip: next time don't use words like "this", but be specific instead. Comments have a tendency to jump around.

Build wheels for Linux-aarch64

1ef8c51

abey79 added 🧑‍💻 dev experience developer experience (excluding CI) include in changelog 🚢 CI labels Mar 14, 2024

abey79 added 3 commits March 14, 2024 18:17

(TEMPORARY) Add linux arm64 build/test on pr

750681c

lint

de2644b

[TEMPORARY] try another way to test the #&%@ build

fdcb625

emilk approved these changes Mar 15, 2024

View reviewed changes

.github/workflows/on_pull_request.yml Show resolved Hide resolved

.github/workflows/on_push_main.yml Outdated Show resolved Hide resolved

pixi.toml Show resolved Hide resolved

abey79 added 3 commits March 15, 2024 08:46

Made pixi.toml possibly compatible with linux-aarch64 + bumped to 0.1…

6aebcae

…6.1 everywhere

Remove pixi workaround

bb9393e

Merge branch 'main' into antoine/wheels-linux-aarch64

f36275d

# Conflicts: # pixi.toml

abey79 mentioned this pull request Mar 15, 2024

Add workflow_dispatch to reusable_build_and_upload_wheels.yml #5522

Merged

5 tasks

Merge branch 'main' into antoine/wheels-linux-aarch64

58b98cc

abey79 marked this pull request as draft March 15, 2024 08:37

abey79 added 9 commits March 15, 2024 10:13

Try with manylinux container?

011b59e

Revert manylinux container and set compat to 2.35 instead

86a0c4b

fix

26463d1

Merge branch 'main' into antoine/wheels-linux-aarch64

d3918ba

spelling

6010ac0

pr tests back to linux-x64

9e42bac

sort some stuff

d6b1083

Merge branch 'main' into antoine/wheels-linux-aarch64

82b4fbe

add rationale for the min test wheel

ca13fdc

abey79 marked this pull request as ready for review March 15, 2024 09:52

jleibs and others added 3 commits March 15, 2024 16:08

use our container for all linux-arm64 build

69e81df

[TEMP] switch to arm for PR wheel build&test

2a4092e

abey79 added 2 commits March 16, 2024 08:11

Revert "[TEMP] switch to arm for PR wheel build&test"

26c27ca

This reverts commit 2a4092e.

always use pixi to build the web viewer (needed for wasm-opt)

f8fcb02

abey79 marked this pull request as draft March 16, 2024 07:15

Merge branch 'main' into antoine/wheels-linux-aarch64

e718959

abey79 marked this pull request as ready for review March 16, 2024 08:34

abey79 mentioned this pull request Mar 16, 2024

Setup.sh is broken on linux. And lots of things are broken on linux-aarch64 #5545

Closed

abey79 added 5 commits March 18, 2024 08:18

Merge branch 'main' into antoine/wheels-linux-aarch64

c1b3397

# Conflicts: # .github/workflows/reusable_test_wheels.yml

Misc minor change to make the reusable_build_* files more similar

838990f

Try remove double google auth in CLI build

cff5b0c

Remove double GCS auth and clarify that setup-rust also auth to gcs

0724ba2

Merge branch 'main' into antoine/wheels-linux-aarch64

c029b41

abey79 merged commit be1fbcc into main Mar 18, 2024
64 checks passed

abey79 deleted the antoine/wheels-linux-aarch64 branch March 18, 2024 13:22

Wumpf mentioned this pull request Mar 19, 2024

Build wheels for abi3-manylinux_2_31_aarch64 #2951

Closed

jprochazk mentioned this pull request Mar 21, 2024

Fix build workflows #5611

Merged

5 tasks

emilk reviewed Apr 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build wheels for Linux ARM64 #5511

Build wheels for Linux ARM64 #5511

abey79 commented Mar 14, 2024 •

edited by github-actions bot

Loading

emilk left a comment

abey79 commented Mar 15, 2024 •

edited

Loading

jleibs commented Mar 15, 2024

abey79 commented Mar 16, 2024

abey79 commented Mar 18, 2024 •

edited

Loading

emilk Apr 10, 2024

abey79 Apr 10, 2024

emilk Apr 10, 2024

		# TODO(#5525): at least this target is broken, maybe others — we currently only use linux-x64 and windows-x64
		run: \|

Build wheels for Linux ARM64 #5511

Build wheels for Linux ARM64 #5511

Conversation

abey79 commented Mar 14, 2024 • edited by github-actions bot Loading

What

Related

Further work

Checklist

emilk left a comment

Choose a reason for hiding this comment

abey79 commented Mar 15, 2024 • edited Loading

jleibs commented Mar 15, 2024

abey79 commented Mar 16, 2024

abey79 commented Mar 18, 2024 • edited Loading

emilk Apr 10, 2024

Choose a reason for hiding this comment

abey79 Apr 10, 2024

Choose a reason for hiding this comment

emilk Apr 10, 2024

Choose a reason for hiding this comment

abey79 commented Mar 14, 2024 •

edited by github-actions bot

Loading

abey79 commented Mar 15, 2024 •

edited

Loading

abey79 commented Mar 18, 2024 •

edited

Loading