-
Notifications
You must be signed in to change notification settings - Fork 373
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Build wheels for Linux ARM64 (#5511)
### What Build linux-aarch64 wheels (with manylinux_2_31) and fixes the C and CLI builds to bring the min required glibc version to 2.31. **Note**: cursory inspection indicates that the _actual_ min glibc version 2.29. However, we don't formally test that. The only test is done by `maturin` on our wheels, against the `manylinux_2_31` standard. Amongst other things, this PR: - updates our ci docker image to be compatible with aarch64 (#5543 – thanks @jleibs) - remove all instances of double GCS authentication (our setup-rust action auth to GCS, so an explicit auth isn't necessary, _and_ would break cleanup in linux-arm/cli build workflow—why there only is unclear) - use it for all linux-aarch64 builds - fixes `pixi.toml` for linux-aarch64 compatibility - bumps pixi to 0.16.1 everywhere in the ci - adds a manual trigger for building wheels - (mostly) unifies the target naming scheme #### Related - Follow-up to: - #5489 - #5503 - Closes #4136 - Fixes #5507 #### Further work - ~~support lower glibc version: #5512 - test more wheels: #5525 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5511/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5511/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5511/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5511) - [Docs preview](https://rerun.io/preview/c029b411730d035b9babdba3f9721dbe2905196b/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/c029b411730d035b9babdba3f9721dbe2905196b/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Jeremy Leibs <[email protected]>
- Loading branch information
Showing
29 changed files
with
6,974 additions
and
1,067 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ jobs: | |
|
||
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: v0.13.0 | ||
pixi-version: v0.16.1 | ||
|
||
- name: Install dependencies | ||
shell: bash | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,7 +86,7 @@ jobs: | |
name: Check if running codegen would produce any changes | ||
runs-on: ubuntu-latest-16-cores | ||
container: | ||
image: rerunio/ci_docker:0.11.0 | ||
image: rerunio/ci_docker:0.12.0 | ||
steps: | ||
# Note: We explicitly don't override `ref` here. We need to see if changes would be made | ||
# in a context where we have merged with main. Otherwise we might miss changes such as one | ||
|
@@ -101,7 +101,7 @@ jobs: | |
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: v0.13.0 | ||
pixi-version: v0.16.1 | ||
|
||
- name: Codegen check | ||
shell: bash | ||
|
@@ -112,7 +112,7 @@ jobs: | |
name: Rust lints (fmt, check, cranky, tests, doc) | ||
runs-on: ubuntu-latest-16-cores | ||
container: | ||
image: rerunio/ci_docker:0.11.0 | ||
image: rerunio/ci_docker:0.12.0 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
|
@@ -183,7 +183,7 @@ jobs: | |
name: Check Rust web build (wasm32 + wasm-bindgen) | ||
runs-on: ubuntu-latest-16-cores | ||
container: | ||
image: rerunio/ci_docker:0.11.0 | ||
image: rerunio/ci_docker:0.12.0 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
|
@@ -212,7 +212,7 @@ jobs: | |
|
||
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: v0.13.0 | ||
pixi-version: v0.16.1 | ||
|
||
- run: pixi run lint-taplo | ||
shell: bash | ||
|
@@ -268,7 +268,7 @@ jobs: | |
name: Cargo Deny | ||
runs-on: ubuntu-latest | ||
container: | ||
image: rerunio/ci_docker:0.11.0 | ||
image: rerunio/ci_docker:0.12.0 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
|
@@ -294,13 +294,13 @@ jobs: | |
name: C++ tests | ||
runs-on: ubuntu-latest | ||
container: | ||
image: rerunio/ci_docker:0.11.0 | ||
image: rerunio/ci_docker:0.12.0 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: v0.13.0 | ||
pixi-version: v0.16.1 | ||
|
||
# TODO(emilk): make this work somehow. Right now this just results in | ||
# > Compiler: GNU 12.3.0 (/__w/rerun/rerun/.pixi/env/bin/x86_64-conda-linux-gnu-c++) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,13 +36,13 @@ jobs: | |
name: Build Wheels | ||
runs-on: ubuntu-latest-16-cores | ||
container: | ||
image: rerunio/ci_docker:0.11.0 | ||
image: rerunio/ci_docker:0.12.0 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: v0.13.0 | ||
pixi-version: v0.16.1 | ||
|
||
# These should already be in the docker container, but run for good measure. A no-op install | ||
# should be fast, and this way things don't break if we add new packages without rebuilding | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,7 +90,7 @@ jobs: | |
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: v0.13.0 | ||
pixi-version: v0.16.1 | ||
|
||
- name: Update crate versions | ||
id: versioning | ||
|
@@ -391,7 +391,7 @@ jobs: | |
|
||
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: v0.13.0 | ||
pixi-version: v0.16.1 | ||
|
||
- name: Install dependencies | ||
shell: bash | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.